test: restore _emit_pass_span residual default
The detail-phase refactor made residual a required positional argument while test_loop_span_accounting.py still calls _emit_pass_span with four arguments, so that test failed on the base commit. Default it to 0.0. Split out of the prefill_batch_init observability series to keep that review scope focused.
This commit is contained in:
@@ -714,7 +714,11 @@ def add_mlp_sync(seconds: float) -> None:
|
||||
|
||||
|
||||
def _emit_pass_span(
|
||||
dp_rank: int, t: PassTimings, total: float, other: float, residual: float
|
||||
dp_rank: int,
|
||||
t: PassTimings,
|
||||
total: float,
|
||||
other: float,
|
||||
residual: float = 0.0,
|
||||
) -> None:
|
||||
if not pass_span_decision(t.seq):
|
||||
return
|
||||
|
||||
Reference in New Issue
Block a user