From 9f9dce1ff6604419958ad9dac926e5a2087f71bf Mon Sep 17 00:00:00 2001 From: ymk Date: Thu, 12 Nov 2026 10:30:17 +0800 Subject: [PATCH] test: restore _emit_pass_span residual default The detail-phase refactor made residual a required positional argument while test_loop_span_accounting.py still calls _emit_pass_span with four arguments, so that test failed on the base commit. Default it to 0.0. Split out of the prefill_batch_init observability series to keep that review scope focused. --- python/sglang/srt/observability/batch_telemetry.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/python/sglang/srt/observability/batch_telemetry.py b/python/sglang/srt/observability/batch_telemetry.py index 742d17d815..f4d0170ffc 100644 --- a/python/sglang/srt/observability/batch_telemetry.py +++ b/python/sglang/srt/observability/batch_telemetry.py @@ -714,7 +714,11 @@ def add_mlp_sync(seconds: float) -> None: def _emit_pass_span( - dp_rank: int, t: PassTimings, total: float, other: float, residual: float + dp_rank: int, + t: PassTimings, + total: float, + other: float, + residual: float = 0.0, ) -> None: if not pass_span_decision(t.seq): return