[CI] [Tracing] Add ci for tracing and fix bugs (#21740)
This commit is contained in:
@@ -2415,9 +2415,10 @@ class TokenizerManager(TokenizerCommunicatorMixin, TokenizerManagerMultiItemMixi
|
||||
return span_attrs
|
||||
|
||||
# Token usage attributes
|
||||
span_attrs[SpanAttributes.GEN_AI_USAGE_COMPLETION_TOKENS] = (
|
||||
recv_obj.completion_tokens[i]
|
||||
)
|
||||
if not isinstance(recv_obj, BatchEmbeddingOutput):
|
||||
span_attrs[SpanAttributes.GEN_AI_USAGE_COMPLETION_TOKENS] = (
|
||||
recv_obj.completion_tokens[i]
|
||||
)
|
||||
span_attrs[SpanAttributes.GEN_AI_USAGE_PROMPT_TOKENS] = recv_obj.prompt_tokens[
|
||||
i
|
||||
]
|
||||
|
||||
@@ -218,9 +218,9 @@ mark_step_done "Uninstall Flashinfer"
|
||||
# Install main package
|
||||
# ------------------------------------------------------------------------------
|
||||
# Install the main package
|
||||
EXTRAS="dev,runai"
|
||||
EXTRAS="dev,runai,tracing"
|
||||
if [ -n "$OPTIONAL_DEPS" ]; then
|
||||
EXTRAS="dev,runai,${OPTIONAL_DEPS}"
|
||||
EXTRAS="dev,runai,tracing,${OPTIONAL_DEPS}"
|
||||
fi
|
||||
echo "Installing python extras: [${EXTRAS}]"
|
||||
source "$(dirname "$0")/cache_nvidia_wheels.sh"
|
||||
|
||||
@@ -1,314 +0,0 @@
|
||||
import multiprocessing as mp
|
||||
import os
|
||||
import subprocess
|
||||
import time
|
||||
import unittest
|
||||
from dataclasses import dataclass
|
||||
from typing import Optional, Union
|
||||
|
||||
import requests
|
||||
import zmq
|
||||
|
||||
from sglang import Engine
|
||||
from sglang.srt.observability.trace import *
|
||||
from sglang.srt.observability.trace import get_cur_time_ns, set_global_trace_level
|
||||
from sglang.srt.utils import kill_process_tree
|
||||
from sglang.srt.utils.network import get_zmq_socket
|
||||
from sglang.test.test_utils import (
|
||||
DEFAULT_SMALL_MODEL_NAME_FOR_TEST,
|
||||
DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
|
||||
DEFAULT_URL_FOR_TEST,
|
||||
CustomTestCase,
|
||||
popen_launch_server,
|
||||
)
|
||||
|
||||
|
||||
@dataclass
|
||||
class Req:
|
||||
rid: int
|
||||
req_context: Optional[Union[TraceReqContext]] = None
|
||||
|
||||
|
||||
class TestTrace(CustomTestCase):
|
||||
def __launch_otel_jaeger(self):
|
||||
cmd = [
|
||||
"docker",
|
||||
"compose",
|
||||
"-f",
|
||||
"../../examples/monitoring/tracing_compose.yaml",
|
||||
"up",
|
||||
"-d",
|
||||
]
|
||||
proc = subprocess.run(cmd)
|
||||
|
||||
if proc.returncode != 0:
|
||||
print("launch opentelemetry collector and jaeger docker err")
|
||||
return False
|
||||
return True
|
||||
|
||||
def __stop_otel_jaeger(self):
|
||||
cmd = [
|
||||
"docker",
|
||||
"compose",
|
||||
"-f",
|
||||
"../../examples/monitoring/tracing_compose.yaml",
|
||||
"down",
|
||||
]
|
||||
proc = subprocess.run(cmd)
|
||||
|
||||
if proc.returncode != 0:
|
||||
print("stop opentelemetry collector and jaeger docker err")
|
||||
return False
|
||||
return True
|
||||
|
||||
def __clear_trace_file(self):
|
||||
try:
|
||||
os.remove("/tmp/otel_trace.json")
|
||||
except:
|
||||
pass
|
||||
|
||||
def __test_trace_enable(self, trace_level, expect_export_data):
|
||||
self.__clear_trace_file()
|
||||
assert self.__launch_otel_jaeger()
|
||||
self.addCleanup(self.__stop_otel_jaeger)
|
||||
|
||||
process = popen_launch_server(
|
||||
DEFAULT_SMALL_MODEL_NAME_FOR_TEST,
|
||||
DEFAULT_URL_FOR_TEST,
|
||||
timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
|
||||
other_args=[
|
||||
"--enable-trace",
|
||||
"--otlp-traces-endpoint",
|
||||
"0.0.0.0:4317",
|
||||
],
|
||||
)
|
||||
|
||||
try:
|
||||
response = requests.get(f"{DEFAULT_URL_FOR_TEST}/health_generate")
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
# set trace level
|
||||
response = requests.get(
|
||||
f"{DEFAULT_URL_FOR_TEST}/set_trace_level?level={trace_level}"
|
||||
)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
# Make some requests to generate trace data
|
||||
response = requests.post(
|
||||
f"{DEFAULT_URL_FOR_TEST}/generate",
|
||||
json={
|
||||
"text": "The capital of France is",
|
||||
"sampling_params": {
|
||||
"temperature": 0,
|
||||
"max_new_tokens": 32,
|
||||
},
|
||||
"stream": True,
|
||||
},
|
||||
stream=True,
|
||||
)
|
||||
for _ in response.iter_lines(decode_unicode=False):
|
||||
pass
|
||||
|
||||
# sleep for a few seconds to wait for opentelemetry collector to asynchronously export data to file.
|
||||
time.sleep(10)
|
||||
|
||||
# check trace file
|
||||
assert os.path.isfile("/tmp/otel_trace.json"), "trace file not exist"
|
||||
if expect_export_data:
|
||||
assert (
|
||||
os.path.getsize("/tmp/otel_trace.json") > 0
|
||||
), "trace file is empty"
|
||||
else:
|
||||
assert (
|
||||
os.path.getsize("/tmp/otel_trace.json") == 0
|
||||
), "trace file is not empty"
|
||||
|
||||
finally:
|
||||
kill_process_tree(process.pid)
|
||||
|
||||
def test_trace_enable_level_1(self):
|
||||
self.__test_trace_enable("1", True)
|
||||
|
||||
def test_trace_enable_level_2(self):
|
||||
self.__test_trace_enable("2", True)
|
||||
|
||||
def test_trace_enable_level_3(self):
|
||||
self.__test_trace_enable("3", True)
|
||||
|
||||
def test_trace_enable_level_0(self):
|
||||
self.__test_trace_enable("0", False)
|
||||
|
||||
def test_trace_engine_enable(self):
|
||||
self.__clear_trace_file()
|
||||
assert self.__launch_otel_jaeger()
|
||||
self.addCleanup(self.__stop_otel_jaeger)
|
||||
|
||||
prompt = "Today is a sunny day and I like"
|
||||
model_path = DEFAULT_SMALL_MODEL_NAME_FOR_TEST
|
||||
|
||||
sampling_params = {"temperature": 0, "max_new_tokens": 8}
|
||||
|
||||
engine = Engine(
|
||||
model_path=model_path,
|
||||
random_seed=42,
|
||||
enable_trace=True,
|
||||
otlp_traces_endpoint="localhost:4317",
|
||||
)
|
||||
|
||||
try:
|
||||
engine.generate(prompt, sampling_params)
|
||||
|
||||
# sleep for a few seconds to wait for opentelemetry collector to asynchronously export data to file.
|
||||
time.sleep(10)
|
||||
|
||||
# check trace file
|
||||
assert os.path.isfile("/tmp/otel_trace.json"), "trace file not exist"
|
||||
assert os.path.getsize("/tmp/otel_trace.json") > 0, "trace file is empty"
|
||||
finally:
|
||||
engine.shutdown()
|
||||
|
||||
def test_trace_engine_encode(self):
|
||||
self.__clear_trace_file()
|
||||
assert self.__launch_otel_jaeger()
|
||||
self.addCleanup(self.__stop_otel_jaeger)
|
||||
|
||||
prompt = "Today is a sunny day and I like"
|
||||
model_path = "Qwen/Qwen2-7B"
|
||||
|
||||
engine = Engine(
|
||||
model_path=model_path,
|
||||
random_seed=42,
|
||||
enable_trace=True,
|
||||
otlp_traces_endpoint="localhost:4317",
|
||||
is_embedding=True,
|
||||
)
|
||||
|
||||
try:
|
||||
engine.encode(prompt)
|
||||
|
||||
# sleep for a few seconds to wait for opentelemetry collector to asynchronously export data to file.
|
||||
time.sleep(10)
|
||||
|
||||
# check trace file
|
||||
assert os.path.isfile("/tmp/otel_trace.json"), "trace file not exist"
|
||||
assert os.path.getsize("/tmp/otel_trace.json") > 0, "trace file is empty"
|
||||
finally:
|
||||
engine.shutdown()
|
||||
|
||||
def test_slice_trace_simple(self):
|
||||
self.__clear_trace_file()
|
||||
assert self.__launch_otel_jaeger()
|
||||
self.addCleanup(self.__stop_otel_jaeger)
|
||||
try:
|
||||
process_tracing_init("0.0.0.0:4317", "test")
|
||||
trace_set_thread_info("Test")
|
||||
set_global_trace_level(3)
|
||||
req_context = TraceReqContext(0)
|
||||
req_context.trace_req_start()
|
||||
req_context.trace_slice_start("test slice", level=1)
|
||||
time.sleep(1)
|
||||
req_context.trace_slice_end("test slice", level=1)
|
||||
req_context.trace_req_finish()
|
||||
|
||||
# sleep for a few seconds to wait for opentelemetry collector to asynchronously export data to file.
|
||||
time.sleep(10)
|
||||
# check trace file
|
||||
assert os.path.isfile("/tmp/otel_trace.json"), "trace file not exist"
|
||||
assert os.path.getsize("/tmp/otel_trace.json") > 0, "trace file is empty"
|
||||
finally:
|
||||
pass
|
||||
|
||||
def test_slice_trace_complex(self):
|
||||
self.__clear_trace_file()
|
||||
assert self.__launch_otel_jaeger()
|
||||
self.addCleanup(self.__stop_otel_jaeger)
|
||||
try:
|
||||
process_tracing_init("0.0.0.0:4317", "test")
|
||||
trace_set_thread_info("Test")
|
||||
set_global_trace_level(3)
|
||||
req_context = TraceReqContext(0)
|
||||
req_context.trace_req_start()
|
||||
t1 = get_cur_time_ns()
|
||||
time.sleep(1)
|
||||
req_context.trace_event("event test", 1)
|
||||
t2 = get_cur_time_ns()
|
||||
time.sleep(1)
|
||||
t3 = get_cur_time_ns()
|
||||
slice1 = TraceSliceContext("slice A", t1, t2)
|
||||
slice2 = TraceSliceContext("slice B", t2, t3)
|
||||
req_context.trace_slice(slice1)
|
||||
req_context.trace_slice(slice2, thread_finish_flag=True)
|
||||
req_context.trace_req_finish()
|
||||
|
||||
# sleep for a few seconds to wait for opentelemetry collector to asynchronously export data to file.
|
||||
time.sleep(10)
|
||||
# check trace file
|
||||
assert os.path.isfile("/tmp/otel_trace.json"), "trace file not exist"
|
||||
assert os.path.getsize("/tmp/otel_trace.json") > 0, "trace file is empty"
|
||||
finally:
|
||||
pass
|
||||
|
||||
def test_trace_context_propagete(self):
|
||||
def __process_work():
|
||||
process_tracing_init("0.0.0.0:4317", "test")
|
||||
trace_set_thread_info("Sub Process")
|
||||
|
||||
context = zmq.Context(2)
|
||||
recv_from_main = get_zmq_socket(
|
||||
context, zmq.PULL, "ipc:///tmp/zmq_test.ipc", True
|
||||
)
|
||||
|
||||
try:
|
||||
req = recv_from_main.recv_pyobj()
|
||||
req.req_context.rebuild_thread_context()
|
||||
req.req_context.trace_slice_start("work", level=1)
|
||||
time.sleep(1)
|
||||
req.req_context.trace_slice_end(
|
||||
"work", level=1, thread_finish_flag=True
|
||||
)
|
||||
finally:
|
||||
recv_from_main.close()
|
||||
context.term()
|
||||
|
||||
self.__clear_trace_file()
|
||||
assert self.__launch_otel_jaeger()
|
||||
self.addCleanup(self.__stop_otel_jaeger)
|
||||
|
||||
context = zmq.Context(2)
|
||||
send_to_subproc = get_zmq_socket(
|
||||
context, zmq.PUSH, "ipc:///tmp/zmq_test.ipc", False
|
||||
)
|
||||
try:
|
||||
process_tracing_init("0.0.0.0:4317", "test")
|
||||
trace_set_thread_info("Main Process")
|
||||
|
||||
subproc = mp.Process(target=__process_work)
|
||||
subproc.start()
|
||||
|
||||
# sleep for a few second to ensure subprocess init
|
||||
time.sleep(1)
|
||||
|
||||
req = Req(rid=0)
|
||||
req.req_context = TraceReqContext(0)
|
||||
req.req_context.trace_req_start()
|
||||
req.req_context.trace_slice_start("dispatch", level=1)
|
||||
time.sleep(1)
|
||||
send_to_subproc.send_pyobj(req)
|
||||
req.req_context.trace_slice_end("dispatch", level=1)
|
||||
|
||||
subproc.join()
|
||||
req.req_context.trace_req_finish()
|
||||
|
||||
# sleep for a few seconds to wait for opentelemetry collector to asynchronously export data to file.
|
||||
time.sleep(10)
|
||||
# check trace file
|
||||
assert os.path.isfile("/tmp/otel_trace.json"), "trace file not exist"
|
||||
assert os.path.getsize("/tmp/otel_trace.json") > 0, "trace file is empty"
|
||||
|
||||
finally:
|
||||
send_to_subproc.close()
|
||||
context.term()
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
@@ -0,0 +1,794 @@
|
||||
"""Integration tests for tracing with a lightweight in-process OTLP collector.
|
||||
|
||||
This module implements a minimal OTLP collector that receives traces via gRPC
|
||||
and stores them in memory for test assertions, eliminating the need for
|
||||
Docker-based opentelemetry-collector and file I/O.
|
||||
"""
|
||||
|
||||
import os
|
||||
|
||||
# Configure OTLP exporter for faster test execution
|
||||
# Must be set before importing sglang trace module
|
||||
os.environ.setdefault("SGLANG_OTLP_EXPORTER_SCHEDULE_DELAY_MILLIS", "50")
|
||||
os.environ.setdefault("SGLANG_OTLP_EXPORTER_MAX_EXPORT_BATCH_SIZE", "4")
|
||||
|
||||
import json
|
||||
import logging
|
||||
import multiprocessing as mp
|
||||
import threading
|
||||
import time
|
||||
import unittest
|
||||
from concurrent import futures
|
||||
from dataclasses import dataclass, field
|
||||
from typing import Any, Dict, List, Optional, Set, Union
|
||||
|
||||
import requests
|
||||
import zmq
|
||||
|
||||
from sglang import Engine
|
||||
from sglang.srt.observability.req_time_stats import RequestStage
|
||||
from sglang.srt.observability.trace import (
|
||||
TraceReqContext,
|
||||
TraceSliceContext,
|
||||
get_cur_time_ns,
|
||||
process_tracing_init,
|
||||
set_global_trace_level,
|
||||
trace_set_thread_info,
|
||||
)
|
||||
from sglang.srt.utils import kill_process_tree
|
||||
from sglang.srt.utils.network import get_zmq_socket
|
||||
from sglang.test.ci.ci_register import register_cuda_ci
|
||||
from sglang.test.test_utils import (
|
||||
DEFAULT_SMALL_MODEL_NAME_FOR_TEST,
|
||||
DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
|
||||
DEFAULT_URL_FOR_TEST,
|
||||
CustomTestCase,
|
||||
popen_launch_server,
|
||||
)
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
# CI registration
|
||||
register_cuda_ci(est_time=120, suite="stage-b-test-1-gpu-small")
|
||||
|
||||
|
||||
# ============================================================================
|
||||
# Lightweight OTLP Collector (replaces Docker-based otel-collector)
|
||||
# ============================================================================
|
||||
|
||||
|
||||
@dataclass
|
||||
class Span:
|
||||
"""Represents a single span extracted from OTLP trace data."""
|
||||
|
||||
name: str
|
||||
trace_id: str = ""
|
||||
span_id: str = ""
|
||||
parent_span_id: str = ""
|
||||
start_time_ns: int = 0
|
||||
end_time_ns: int = 0
|
||||
attributes: Dict[str, Any] = field(default_factory=dict)
|
||||
events: List[Dict[str, Any]] = field(default_factory=list)
|
||||
|
||||
|
||||
class LightweightOtlpCollector:
|
||||
"""A minimal OTLP collector that stores traces in memory for test assertions.
|
||||
|
||||
This replaces the Docker-based opentelemetry-collector for testing purposes.
|
||||
It listens on a gRPC port for OTLP trace data and stores spans in memory,
|
||||
allowing tests to verify specific spans based on trace level.
|
||||
"""
|
||||
|
||||
def __init__(self, port: int = 4317):
|
||||
self.port = port
|
||||
self._server = None
|
||||
self._thread = None
|
||||
self._running = False
|
||||
self._lock = threading.Lock()
|
||||
# In-memory storage for collected spans
|
||||
self._spans: List[Span] = []
|
||||
self._raw_traces: List[Dict[str, Any]] = []
|
||||
|
||||
def _try_grpc_server(self):
|
||||
"""Try to start gRPC server with full OTLP protocol."""
|
||||
try:
|
||||
from grpc import server as grpc_server
|
||||
from opentelemetry.proto.collector.trace.v1.trace_service_pb2 import (
|
||||
ExportTraceServiceResponse,
|
||||
)
|
||||
from opentelemetry.proto.collector.trace.v1.trace_service_pb2_grpc import (
|
||||
TraceServiceServicer,
|
||||
add_TraceServiceServicer_to_server,
|
||||
)
|
||||
|
||||
class TraceServicer(TraceServiceServicer):
|
||||
def __init__(self, collector):
|
||||
self.collector = collector
|
||||
|
||||
def Export(self, request, context):
|
||||
self.collector._handle_trace_request(request)
|
||||
return ExportTraceServiceResponse()
|
||||
|
||||
self._server = grpc_server(futures.ThreadPoolExecutor(max_workers=4))
|
||||
add_TraceServiceServicer_to_server(TraceServicer(self), self._server)
|
||||
self._server.add_insecure_port(f"127.0.0.1:{self.port}")
|
||||
return True
|
||||
except ImportError:
|
||||
logger.warning("Full gRPC OTLP not available, using HTTP fallback")
|
||||
return False
|
||||
|
||||
def _handle_trace_request(self, request):
|
||||
"""Handle incoming trace request and extract spans to memory."""
|
||||
with self._lock:
|
||||
try:
|
||||
trace_data = self._protobuf_to_dict(request)
|
||||
self._raw_traces.append(trace_data)
|
||||
# Extract spans from the trace data
|
||||
self._extract_spans(trace_data)
|
||||
except Exception as e:
|
||||
logger.error(f"Failed to process trace: {e}")
|
||||
|
||||
def _protobuf_to_dict(self, proto_obj) -> Dict[str, Any]:
|
||||
"""Convert protobuf message to dict."""
|
||||
result = {}
|
||||
for field, value in proto_obj.ListFields():
|
||||
if field.message_type:
|
||||
type_name = type(value).__name__
|
||||
if "Repeated" in type_name:
|
||||
result[field.name] = [self._protobuf_to_dict(v) for v in value]
|
||||
else:
|
||||
result[field.name] = self._protobuf_to_dict(value)
|
||||
else:
|
||||
result[field.name] = value
|
||||
return result
|
||||
|
||||
def _extract_spans(self, trace_data: Dict[str, Any]):
|
||||
"""Extract Span objects from OTLP trace data structure."""
|
||||
resource_spans = trace_data.get("resource_spans", [])
|
||||
for rs in resource_spans:
|
||||
scope_spans = rs.get("scope_spans", [])
|
||||
for ss in scope_spans:
|
||||
spans = ss.get("spans", [])
|
||||
for span_data in spans:
|
||||
span = Span(
|
||||
name=span_data.get("name", ""),
|
||||
trace_id=span_data.get("trace_id", ""),
|
||||
span_id=span_data.get("span_id", ""),
|
||||
parent_span_id=span_data.get("parent_span_id", ""),
|
||||
start_time_ns=span_data.get("start_time_unix_nano", 0),
|
||||
end_time_ns=span_data.get("end_time_unix_nano", 0),
|
||||
attributes=span_data.get("attributes", {}),
|
||||
events=span_data.get("events", []),
|
||||
)
|
||||
self._spans.append(span)
|
||||
|
||||
def _http_server_loop(self):
|
||||
"""Fallback HTTP server for OTLP HTTP protocol."""
|
||||
from http.server import BaseHTTPRequestHandler, HTTPServer
|
||||
|
||||
class OTLPHandler(BaseHTTPRequestHandler):
|
||||
def __init__(self, request, client_address, server):
|
||||
self.collector = server.collector
|
||||
super().__init__(request, client_address, server)
|
||||
|
||||
def do_POST(self):
|
||||
if self.path in ["/v1/traces", "/v1/traces/"]:
|
||||
content_length = int(self.headers.get("Content-Length", 0))
|
||||
body = self.rfile.read(content_length)
|
||||
try:
|
||||
data = json.loads(body)
|
||||
with self.collector._lock:
|
||||
self.collector._raw_traces.append(data)
|
||||
self.collector._extract_spans_http(data)
|
||||
self.send_response(200)
|
||||
self.end_headers()
|
||||
except Exception as e:
|
||||
logger.error(f"HTTP trace handling error: {e}")
|
||||
self.send_response(500)
|
||||
self.end_headers()
|
||||
else:
|
||||
self.send_response(404)
|
||||
self.end_headers()
|
||||
|
||||
def log_message(self, format, *args):
|
||||
pass # Suppress HTTP server logs
|
||||
|
||||
class CollectorHTTPServer(HTTPServer):
|
||||
def __init__(self, server_address, collector):
|
||||
self.collector = collector
|
||||
super().__init__(
|
||||
server_address,
|
||||
lambda r, a, s: OTLPHandler(r, a, s),
|
||||
)
|
||||
|
||||
server = CollectorHTTPServer(("127.0.0.1", 4318), self)
|
||||
server.timeout = 0.5
|
||||
while self._running:
|
||||
server.handle_request()
|
||||
|
||||
def _extract_spans_http(self, data: Dict[str, Any]):
|
||||
"""Extract Span objects from OTLP HTTP JSON format."""
|
||||
resource_spans = data.get("resourceSpans", [])
|
||||
for rs in resource_spans:
|
||||
scope_spans = rs.get("scopeSpans", [])
|
||||
for ss in scope_spans:
|
||||
spans = ss.get("spans", [])
|
||||
for span_data in spans:
|
||||
span = Span(
|
||||
name=span_data.get("name", ""),
|
||||
trace_id=span_data.get("traceId", ""),
|
||||
span_id=span_data.get("spanId", ""),
|
||||
parent_span_id=span_data.get("parentSpanId", ""),
|
||||
start_time_ns=span_data.get("startTimeUnixNano", 0),
|
||||
end_time_ns=span_data.get("endTimeUnixNano", 0),
|
||||
attributes=span_data.get("attributes", {}),
|
||||
events=span_data.get("events", []),
|
||||
)
|
||||
self._spans.append(span)
|
||||
|
||||
def start(self):
|
||||
"""Start the collector server."""
|
||||
self._running = True
|
||||
self._spans.clear()
|
||||
self._raw_traces.clear()
|
||||
if self._try_grpc_server():
|
||||
self._server.start()
|
||||
logger.info(f"OTLP gRPC collector started on port {self.port}")
|
||||
else:
|
||||
# Fallback to HTTP server in a thread
|
||||
self._thread = threading.Thread(target=self._http_server_loop, daemon=True)
|
||||
self._thread.start()
|
||||
logger.info("OTLP HTTP collector started on port 4318")
|
||||
|
||||
def stop(self):
|
||||
"""Stop the collector server."""
|
||||
self._running = False
|
||||
if self._server:
|
||||
self._server.stop(1)
|
||||
self._server = None
|
||||
logger.info("OTLP collector stopped")
|
||||
|
||||
# ========================================================================
|
||||
# Public API for test assertions
|
||||
# ========================================================================
|
||||
|
||||
def get_spans(self) -> List[Span]:
|
||||
"""Get all collected spans."""
|
||||
with self._lock:
|
||||
return list(self._spans)
|
||||
|
||||
def get_span_names(self) -> Set[str]:
|
||||
"""Get all unique span names."""
|
||||
with self._lock:
|
||||
return {s.name for s in self._spans}
|
||||
|
||||
def has_span(self, name: str) -> bool:
|
||||
"""Check if a span with the given name exists."""
|
||||
return name in self.get_span_names()
|
||||
|
||||
def has_any_span(self, names: List[str]) -> bool:
|
||||
"""Check if any of the given span names exist."""
|
||||
span_names = self.get_span_names()
|
||||
return any(name in span_names for name in names)
|
||||
|
||||
def has_all_spans(self, names: List[str]) -> bool:
|
||||
"""Check if all of the given span names exist."""
|
||||
span_names = self.get_span_names()
|
||||
return all(name in span_names for name in names)
|
||||
|
||||
def get_spans_by_name(self, name: str) -> List[Span]:
|
||||
"""Get all spans with the given name."""
|
||||
with self._lock:
|
||||
return [s for s in self._spans if s.name == name]
|
||||
|
||||
def count_spans(self) -> int:
|
||||
"""Get total count of collected spans."""
|
||||
with self._lock:
|
||||
return len(self._spans)
|
||||
|
||||
def clear(self):
|
||||
"""Clear all collected spans."""
|
||||
with self._lock:
|
||||
self._spans.clear()
|
||||
self._raw_traces.clear()
|
||||
|
||||
|
||||
# ============================================================================
|
||||
# Test Helper Functions
|
||||
# ============================================================================
|
||||
|
||||
|
||||
def _get_span_names_by_level(level: int) -> List[str]:
|
||||
"""Get expected span names for a given trace level.
|
||||
|
||||
Based on RequestStage definitions in req_time_stats.py:
|
||||
- Each RequestStage has a level attribute indicating minimum trace level required
|
||||
- Spans with level <= current trace level will be exported
|
||||
"""
|
||||
span_names = []
|
||||
# RequestStage is a class with class attributes that are RequestStageConfig instances
|
||||
for attr_name in dir(RequestStage):
|
||||
if attr_name.startswith("_"):
|
||||
continue
|
||||
attr = getattr(RequestStage, attr_name)
|
||||
# Check if it's a RequestStageConfig (has stage_name and level attributes)
|
||||
if hasattr(attr, "stage_name") and hasattr(attr, "level"):
|
||||
if attr.level <= level and attr.stage_name:
|
||||
span_names.append(attr.stage_name)
|
||||
return span_names
|
||||
|
||||
|
||||
# Pre-computed span names by level for efficiency
|
||||
SPAN_NAMES_LEVEL_1 = _get_span_names_by_level(1)
|
||||
SPAN_NAMES_LEVEL_2 = _get_span_names_by_level(2)
|
||||
SPAN_NAMES_LEVEL_3 = _get_span_names_by_level(3)
|
||||
|
||||
# Common span names expected in typical inference requests
|
||||
# Level 1: Basic request lifecycle
|
||||
EXPECTED_SPANS_LEVEL_1 = [
|
||||
RequestStage.PREFILL_FORWARD.stage_name,
|
||||
RequestStage.DECODE_FORWARD.stage_name,
|
||||
]
|
||||
|
||||
# Level 2: More detailed including dispatch
|
||||
EXPECTED_SPANS_LEVEL_2 = EXPECTED_SPANS_LEVEL_1 + [
|
||||
RequestStage.REQUEST_PROCESS.stage_name,
|
||||
]
|
||||
|
||||
# Level 3: Most detailed including internal operations
|
||||
EXPECTED_SPANS_LEVEL_3 = EXPECTED_SPANS_LEVEL_2 + [
|
||||
RequestStage.DECODE_LOOP.stage_name,
|
||||
]
|
||||
|
||||
|
||||
@dataclass
|
||||
class Req:
|
||||
rid: int
|
||||
req_context: Optional[Union[TraceReqContext]] = None
|
||||
|
||||
|
||||
def _subprocess_worker():
|
||||
"""Worker function for subprocess trace context propagation test.
|
||||
Must be at module level for pickle compatibility with spawn.
|
||||
"""
|
||||
process_tracing_init("127.0.0.1:4317", "test")
|
||||
trace_set_thread_info("Sub Process")
|
||||
|
||||
context = zmq.Context(2)
|
||||
recv_from_main = get_zmq_socket(context, zmq.PULL, "ipc:///tmp/zmq_test.ipc", True)
|
||||
|
||||
try:
|
||||
req = recv_from_main.recv_pyobj()
|
||||
req.req_context.rebuild_thread_context()
|
||||
req.req_context.trace_slice_start("work", level=1)
|
||||
time.sleep(0.2)
|
||||
req.req_context.trace_slice_end("work", level=1, thread_finish_flag=True)
|
||||
finally:
|
||||
recv_from_main.close()
|
||||
context.term()
|
||||
|
||||
|
||||
# ============================================================================
|
||||
# Test Cases
|
||||
# ============================================================================
|
||||
|
||||
|
||||
class TestTracePackage(CustomTestCase):
|
||||
"""Unit tests for tracing package API without server/engine."""
|
||||
|
||||
def setUp(self):
|
||||
self.collector = None
|
||||
|
||||
def tearDown(self):
|
||||
if self.collector:
|
||||
self.collector.stop()
|
||||
self.collector = None
|
||||
|
||||
def _start_collector(self):
|
||||
"""Start the lightweight OTLP collector."""
|
||||
self.collector = LightweightOtlpCollector()
|
||||
self.collector.start()
|
||||
time.sleep(0.2)
|
||||
|
||||
def test_slice_simple(self):
|
||||
"""Unit test: simple slice trace API."""
|
||||
self._start_collector()
|
||||
|
||||
try:
|
||||
process_tracing_init("127.0.0.1:4317", "test")
|
||||
trace_set_thread_info("Test")
|
||||
set_global_trace_level(3)
|
||||
req_context = TraceReqContext(0)
|
||||
req_context.trace_req_start()
|
||||
req_context.trace_slice_start("test slice", level=1)
|
||||
time.sleep(0.1)
|
||||
req_context.trace_slice_end("test slice", level=1)
|
||||
req_context.trace_req_finish()
|
||||
|
||||
time.sleep(0.3)
|
||||
|
||||
self.assertTrue(
|
||||
self.collector.has_span("test slice"),
|
||||
f"Expected span 'test slice', got {self.collector.get_span_names()}",
|
||||
)
|
||||
finally:
|
||||
pass
|
||||
|
||||
def test_slice_complex(self):
|
||||
"""Unit test: complex slice trace with events."""
|
||||
self._start_collector()
|
||||
|
||||
try:
|
||||
process_tracing_init("127.0.0.1:4317", "test")
|
||||
trace_set_thread_info("Test")
|
||||
set_global_trace_level(3)
|
||||
req_context = TraceReqContext(0)
|
||||
req_context.trace_req_start()
|
||||
|
||||
t1 = get_cur_time_ns()
|
||||
time.sleep(0.1)
|
||||
req_context.trace_event("event test", 1)
|
||||
t2 = get_cur_time_ns()
|
||||
time.sleep(0.1)
|
||||
t3 = get_cur_time_ns()
|
||||
|
||||
slice1 = TraceSliceContext("slice A", t1, t2)
|
||||
slice2 = TraceSliceContext("slice B", t2, t3)
|
||||
req_context.trace_slice(slice1)
|
||||
req_context.trace_slice(slice2, thread_finish_flag=True)
|
||||
req_context.trace_req_finish()
|
||||
|
||||
time.sleep(0.3)
|
||||
|
||||
self.assertTrue(
|
||||
self.collector.has_all_spans(["slice A", "slice B"]),
|
||||
f"Expected spans 'slice A' and 'slice B', got {self.collector.get_span_names()}",
|
||||
)
|
||||
finally:
|
||||
pass
|
||||
|
||||
def test_context_propagate(self):
|
||||
"""Unit test: trace context propagation across processes via ZMQ."""
|
||||
self._start_collector()
|
||||
|
||||
ctx = mp.get_context("spawn")
|
||||
|
||||
context = zmq.Context(2)
|
||||
send_to_subproc = get_zmq_socket(
|
||||
context, zmq.PUSH, "ipc:///tmp/zmq_test.ipc", False
|
||||
)
|
||||
|
||||
try:
|
||||
process_tracing_init("127.0.0.1:4317", "test")
|
||||
trace_set_thread_info("Main Process")
|
||||
|
||||
subproc = ctx.Process(target=_subprocess_worker)
|
||||
subproc.start()
|
||||
|
||||
time.sleep(0.3)
|
||||
|
||||
req = Req(rid=0)
|
||||
req.req_context = TraceReqContext(0)
|
||||
req.req_context.trace_req_start()
|
||||
req.req_context.trace_slice_start("dispatch", level=1)
|
||||
time.sleep(0.2)
|
||||
send_to_subproc.send_pyobj(req)
|
||||
req.req_context.trace_slice_end("dispatch", level=1)
|
||||
|
||||
subproc.join()
|
||||
req.req_context.trace_req_finish()
|
||||
|
||||
time.sleep(0.5)
|
||||
|
||||
self.assertTrue(
|
||||
self.collector.has_all_spans(["dispatch", "work"]),
|
||||
f"Expected spans 'dispatch' and 'work', got {self.collector.get_span_names()}",
|
||||
)
|
||||
finally:
|
||||
send_to_subproc.close()
|
||||
context.term()
|
||||
|
||||
|
||||
class TestTraceServer(CustomTestCase):
|
||||
"""Integration tests for tracing with server - starts server once for all tests."""
|
||||
|
||||
@classmethod
|
||||
def setUpClass(cls):
|
||||
"""Start collector and server once for all tests."""
|
||||
cls.collector = LightweightOtlpCollector()
|
||||
cls.collector.start()
|
||||
time.sleep(0.2)
|
||||
|
||||
cls.process = popen_launch_server(
|
||||
DEFAULT_SMALL_MODEL_NAME_FOR_TEST,
|
||||
DEFAULT_URL_FOR_TEST,
|
||||
timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
|
||||
other_args=[
|
||||
"--enable-trace",
|
||||
"--otlp-traces-endpoint",
|
||||
"127.0.0.1:4317",
|
||||
],
|
||||
)
|
||||
|
||||
response = requests.get(f"{DEFAULT_URL_FOR_TEST}/health_generate")
|
||||
assert response.status_code == 200
|
||||
|
||||
# Wait for warmup spans to be exported
|
||||
cls.collector.clear()
|
||||
|
||||
@classmethod
|
||||
def tearDownClass(cls):
|
||||
if cls.process:
|
||||
kill_process_tree(cls.process.pid)
|
||||
if cls.collector:
|
||||
cls.collector.stop()
|
||||
|
||||
def setUp(self):
|
||||
"""Wait for spans to be drained before each test."""
|
||||
max_wait_seconds = 10
|
||||
check_interval = 0.2
|
||||
elapsed = 0
|
||||
consecutive_zero_count = 0
|
||||
required_consecutive_zeros = 3
|
||||
|
||||
while elapsed < max_wait_seconds:
|
||||
span_count = self.collector.count_spans()
|
||||
if span_count == 0:
|
||||
consecutive_zero_count += 1
|
||||
if consecutive_zero_count >= required_consecutive_zeros:
|
||||
break
|
||||
else:
|
||||
consecutive_zero_count = 0
|
||||
self.collector.clear()
|
||||
time.sleep(check_interval)
|
||||
elapsed += check_interval
|
||||
else:
|
||||
raise RuntimeError(
|
||||
f"Timeout waiting for spans to drain after {max_wait_seconds}s. "
|
||||
f"Remaining spans: {self.collector.count_spans()}"
|
||||
)
|
||||
|
||||
def _send_request_and_wait(
|
||||
self, text, max_new_tokens=32, stream=True, trace_level=None
|
||||
):
|
||||
"""Helper to send a request and wait for spans."""
|
||||
if trace_level is not None:
|
||||
response = requests.get(
|
||||
f"{DEFAULT_URL_FOR_TEST}/set_trace_level?level={trace_level}"
|
||||
)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.collector.clear()
|
||||
|
||||
response = requests.post(
|
||||
f"{DEFAULT_URL_FOR_TEST}/generate",
|
||||
json={
|
||||
"text": text,
|
||||
"sampling_params": {
|
||||
"temperature": 0,
|
||||
"max_new_tokens": max_new_tokens,
|
||||
},
|
||||
"stream": stream,
|
||||
},
|
||||
stream=stream,
|
||||
)
|
||||
if stream:
|
||||
for _ in response.iter_lines(decode_unicode=False):
|
||||
pass
|
||||
else:
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
time.sleep(1)
|
||||
|
||||
def test_trace_level_0(self):
|
||||
"""Test trace level 0 does not export any spans."""
|
||||
self._send_request_and_wait("Hello world", max_new_tokens=5, trace_level=0)
|
||||
self.assertEqual(
|
||||
self.collector.count_spans(),
|
||||
0,
|
||||
f"Spans collected but expected none: {sorted(self.collector.get_span_names())}",
|
||||
)
|
||||
|
||||
def test_trace_level_1(self):
|
||||
"""Test trace level 1 exports basic request lifecycle spans."""
|
||||
self._send_request_and_wait("The capital of France is", trace_level=1)
|
||||
|
||||
self.assertGreater(
|
||||
self.collector.count_spans(),
|
||||
0,
|
||||
"No spans collected but expected some",
|
||||
)
|
||||
|
||||
span_names = self.collector.get_span_names()
|
||||
matched = [name for name in EXPECTED_SPANS_LEVEL_1 if name in span_names]
|
||||
self.assertGreater(
|
||||
len(matched),
|
||||
0,
|
||||
f"No expected spans found. Expected any of {EXPECTED_SPANS_LEVEL_1}, "
|
||||
f"got {sorted(span_names)}",
|
||||
)
|
||||
|
||||
def test_trace_level_2(self):
|
||||
"""Test trace level 2 exports more detailed spans."""
|
||||
self._send_request_and_wait("What is AI?", trace_level=2)
|
||||
|
||||
span_names = self.collector.get_span_names()
|
||||
matched = [name for name in EXPECTED_SPANS_LEVEL_2 if name in span_names]
|
||||
self.assertGreater(
|
||||
len(matched),
|
||||
0,
|
||||
f"No expected spans found. Expected any of {EXPECTED_SPANS_LEVEL_2}, "
|
||||
f"got {sorted(span_names)}",
|
||||
)
|
||||
|
||||
def test_trace_level_3(self):
|
||||
"""Test trace level 3 exports most detailed spans."""
|
||||
self._send_request_and_wait("Explain quantum computing", trace_level=3)
|
||||
|
||||
span_names = self.collector.get_span_names()
|
||||
matched = [name for name in EXPECTED_SPANS_LEVEL_3 if name in span_names]
|
||||
self.assertGreater(
|
||||
len(matched),
|
||||
0,
|
||||
f"No expected spans found. Expected any of {EXPECTED_SPANS_LEVEL_3}, "
|
||||
f"got {sorted(span_names)}",
|
||||
)
|
||||
|
||||
def test_batch_request(self):
|
||||
"""Test tracing with batch requests (multiple prompts in one request)."""
|
||||
response = requests.get(f"{DEFAULT_URL_FOR_TEST}/set_trace_level?level=1")
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.collector.clear()
|
||||
|
||||
batch_size = 4
|
||||
prompts = ["The capital of France is"] * batch_size
|
||||
response = requests.post(
|
||||
f"{DEFAULT_URL_FOR_TEST}/generate",
|
||||
json={
|
||||
"text": prompts,
|
||||
"sampling_params": {
|
||||
"temperature": 0,
|
||||
"max_new_tokens": 10,
|
||||
},
|
||||
"stream": False,
|
||||
},
|
||||
)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
time.sleep(0.5)
|
||||
|
||||
self.assertGreater(
|
||||
self.collector.count_spans(),
|
||||
0,
|
||||
"No spans collected from batch request",
|
||||
)
|
||||
|
||||
all_spans = self.collector.get_spans()
|
||||
request_spans = [
|
||||
s for s in all_spans if s.name == RequestStage.PREFILL_FORWARD.stage_name
|
||||
]
|
||||
self.assertEqual(
|
||||
len(request_spans),
|
||||
batch_size,
|
||||
f"Expected {batch_size} prefill_forward spans, got {len(request_spans)}",
|
||||
)
|
||||
|
||||
def test_parallel_sample(self):
|
||||
"""Test tracing with parallel sampling (n > 1 in sampling_params)."""
|
||||
response = requests.get(f"{DEFAULT_URL_FOR_TEST}/set_trace_level?level=1")
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.collector.clear()
|
||||
|
||||
# parallel_sample_num is controlled by 'n' in sampling_params
|
||||
parallel_num = 4
|
||||
response = requests.post(
|
||||
f"{DEFAULT_URL_FOR_TEST}/generate",
|
||||
json={
|
||||
"text": "The capital of France is",
|
||||
"sampling_params": {
|
||||
"temperature": 0.5, # Need non-zero temp for parallel sampling
|
||||
"max_new_tokens": 10,
|
||||
"n": parallel_num,
|
||||
},
|
||||
"stream": False,
|
||||
},
|
||||
)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
time.sleep(0.5)
|
||||
|
||||
self.assertGreater(
|
||||
self.collector.count_spans(),
|
||||
0,
|
||||
"No spans collected from parallel sample request",
|
||||
)
|
||||
|
||||
# With parallel sampling, we expect prefill spans for each parallel sample
|
||||
all_spans = self.collector.get_spans()
|
||||
request_spans = [
|
||||
s for s in all_spans if s.name == RequestStage.PREFILL_FORWARD.stage_name
|
||||
]
|
||||
self.assertGreaterEqual(
|
||||
len(request_spans),
|
||||
1,
|
||||
f"Expected at least 1 prefill_forward span, got {len(request_spans)}",
|
||||
)
|
||||
|
||||
|
||||
class TestTraceEngine(CustomTestCase):
|
||||
"""Integration tests for tracing with Engine API - each test creates its own engine."""
|
||||
|
||||
def setUp(self):
|
||||
self.collector = None
|
||||
|
||||
def tearDown(self):
|
||||
if self.collector:
|
||||
self.collector.stop()
|
||||
self.collector = None
|
||||
|
||||
def _start_collector(self):
|
||||
"""Start the lightweight OTLP collector."""
|
||||
self.collector = LightweightOtlpCollector()
|
||||
self.collector.start()
|
||||
time.sleep(0.2)
|
||||
|
||||
def test_trace_engine_enable(self):
|
||||
"""Test tracing with Engine API."""
|
||||
self._start_collector()
|
||||
|
||||
prompt = "Today is a sunny day and I like"
|
||||
model_path = DEFAULT_SMALL_MODEL_NAME_FOR_TEST
|
||||
sampling_params = {"temperature": 0, "max_new_tokens": 8}
|
||||
|
||||
engine = Engine(
|
||||
model_path=model_path,
|
||||
random_seed=42,
|
||||
enable_trace=True,
|
||||
otlp_traces_endpoint="localhost:4317",
|
||||
)
|
||||
|
||||
try:
|
||||
engine.generate(prompt, sampling_params)
|
||||
time.sleep(0.5)
|
||||
|
||||
self.assertGreater(
|
||||
self.collector.count_spans(),
|
||||
0,
|
||||
"No spans collected from Engine.generate",
|
||||
)
|
||||
self.assertTrue(
|
||||
self.collector.has_any_span([RequestStage.PREFILL_FORWARD.stage_name]),
|
||||
f"Expected prefill_forward span, got {self.collector.get_span_names()}",
|
||||
)
|
||||
finally:
|
||||
engine.shutdown()
|
||||
|
||||
def test_trace_engine_encode(self):
|
||||
"""Test tracing with Engine encode API."""
|
||||
self._start_collector()
|
||||
|
||||
prompt = "Today is a sunny day and I like"
|
||||
model_path = DEFAULT_SMALL_MODEL_NAME_FOR_TEST
|
||||
|
||||
engine = Engine(
|
||||
model_path=model_path,
|
||||
random_seed=42,
|
||||
enable_trace=True,
|
||||
otlp_traces_endpoint="localhost:4317",
|
||||
is_embedding=True,
|
||||
)
|
||||
|
||||
try:
|
||||
engine.encode(prompt)
|
||||
time.sleep(0.5)
|
||||
|
||||
self.assertGreater(
|
||||
self.collector.count_spans(),
|
||||
0,
|
||||
"No spans collected from Engine.encode",
|
||||
)
|
||||
finally:
|
||||
engine.shutdown()
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
@@ -0,0 +1,237 @@
|
||||
"""Test tracing in PD disaggregation mode."""
|
||||
|
||||
import os
|
||||
|
||||
# Configure OTLP exporter for faster test execution
|
||||
# Must be set before importing sglang trace module
|
||||
os.environ.setdefault("SGLANG_OTLP_EXPORTER_SCHEDULE_DELAY_MILLIS", "50")
|
||||
os.environ.setdefault("SGLANG_OTLP_EXPORTER_MAX_EXPORT_BATCH_SIZE", "4")
|
||||
|
||||
import logging
|
||||
import shlex
|
||||
import time
|
||||
import unittest
|
||||
from urllib.parse import urlparse
|
||||
|
||||
import requests
|
||||
|
||||
# Import the lightweight collector from the main tracing test module
|
||||
from test_tracing import LightweightOtlpCollector
|
||||
|
||||
from sglang.srt.observability.req_time_stats import RequestStage
|
||||
from sglang.srt.utils import kill_process_tree
|
||||
from sglang.test.ci.ci_register import register_cuda_ci
|
||||
from sglang.test.server_fixtures.disaggregation_fixture import get_rdma_devices_args
|
||||
from sglang.test.test_utils import (
|
||||
DEFAULT_MODEL_NAME_FOR_TEST,
|
||||
DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
|
||||
DEFAULT_URL_FOR_TEST,
|
||||
CustomTestCase,
|
||||
popen_launch_pd_server,
|
||||
popen_with_error_check,
|
||||
)
|
||||
from sglang.utils import wait_for_http_ready
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
# CI registration - PD disaggregation requires 2 GPUs
|
||||
register_cuda_ci(est_time=45, suite="stage-b-test-2-gpu-large")
|
||||
|
||||
|
||||
class TestTraceDisaggregation(CustomTestCase):
|
||||
"""Test tracing in PD disaggregation mode."""
|
||||
|
||||
@classmethod
|
||||
def setUpClass(cls):
|
||||
# Initialize collector first
|
||||
cls.collector = LightweightOtlpCollector()
|
||||
cls.collector.start()
|
||||
time.sleep(0.2)
|
||||
|
||||
# Setup PD disaggregation server addresses
|
||||
parsed_url = urlparse(DEFAULT_URL_FOR_TEST)
|
||||
cls.base_host = parsed_url.hostname
|
||||
base_port = str(parsed_url.port)
|
||||
cls.lb_port = base_port
|
||||
cls.prefill_port = f"{int(base_port) + 100}"
|
||||
cls.decode_port = f"{int(base_port) + 200}"
|
||||
cls.bootstrap_port = f"{int(base_port) + 500}"
|
||||
cls.prefill_url = f"http://{cls.base_host}:{cls.prefill_port}"
|
||||
cls.decode_url = f"http://{cls.base_host}:{cls.decode_port}"
|
||||
cls.lb_url = f"http://{cls.base_host}:{cls.lb_port}"
|
||||
cls.process_lb = None
|
||||
cls.process_decode = None
|
||||
cls.process_prefill = None
|
||||
cls.model = DEFAULT_MODEL_NAME_FOR_TEST
|
||||
|
||||
# Config transfer backend
|
||||
cls.transfer_backend = ["--disaggregation-transfer-backend", "mooncake"]
|
||||
cls.rdma_devices = ["--disaggregation-ib-device", get_rdma_devices_args()]
|
||||
|
||||
# Start prefill server with trace enabled
|
||||
prefill_args = [
|
||||
"--trust-remote-code",
|
||||
"--disaggregation-mode",
|
||||
"prefill",
|
||||
"--disaggregation-bootstrap-port",
|
||||
cls.bootstrap_port,
|
||||
"--tp",
|
||||
"1",
|
||||
"--enable-trace",
|
||||
"--otlp-traces-endpoint",
|
||||
"localhost:4317",
|
||||
]
|
||||
prefill_args += cls.transfer_backend + cls.rdma_devices
|
||||
cls.process_prefill = popen_launch_pd_server(
|
||||
cls.model,
|
||||
cls.prefill_url,
|
||||
timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
|
||||
other_args=prefill_args,
|
||||
)
|
||||
|
||||
# Start decode server with trace enabled
|
||||
decode_args = [
|
||||
"--trust-remote-code",
|
||||
"--disaggregation-mode",
|
||||
"decode",
|
||||
"--disaggregation-bootstrap-port",
|
||||
cls.bootstrap_port,
|
||||
"--tp",
|
||||
"1",
|
||||
"--base-gpu-id",
|
||||
"1",
|
||||
"--enable-trace",
|
||||
"--otlp-traces-endpoint",
|
||||
"localhost:4317",
|
||||
]
|
||||
decode_args += cls.transfer_backend + cls.rdma_devices
|
||||
cls.process_decode = popen_launch_pd_server(
|
||||
cls.model,
|
||||
cls.decode_url,
|
||||
timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
|
||||
other_args=decode_args,
|
||||
)
|
||||
|
||||
# Wait for servers to be ready
|
||||
wait_for_http_ready(
|
||||
url=cls.prefill_url + "/health",
|
||||
timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
|
||||
process=cls.process_prefill,
|
||||
)
|
||||
wait_for_http_ready(
|
||||
url=cls.decode_url + "/health",
|
||||
timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
|
||||
process=cls.process_decode,
|
||||
)
|
||||
|
||||
# Start load balancer
|
||||
lb_command = [
|
||||
"python3",
|
||||
"-m",
|
||||
"sglang_router.launch_router",
|
||||
"--pd-disaggregation",
|
||||
"--mini-lb",
|
||||
"--prefill",
|
||||
cls.prefill_url,
|
||||
"--decode",
|
||||
cls.decode_url,
|
||||
"--host",
|
||||
cls.base_host,
|
||||
"--port",
|
||||
cls.lb_port,
|
||||
]
|
||||
print("Starting load balancer:", shlex.join(lb_command))
|
||||
cls.process_lb = popen_with_error_check(lb_command)
|
||||
wait_for_http_ready(url=cls.lb_url + "/health", process=cls.process_lb)
|
||||
|
||||
# Wait for warmup spans and clear
|
||||
time.sleep(1)
|
||||
cls.collector.clear()
|
||||
|
||||
@classmethod
|
||||
def tearDownClass(cls):
|
||||
for process in [cls.process_lb, cls.process_decode, cls.process_prefill]:
|
||||
if process:
|
||||
try:
|
||||
kill_process_tree(process.pid)
|
||||
except Exception as e:
|
||||
print(f"Error killing process {process.pid}: {e}")
|
||||
if cls.collector:
|
||||
cls.collector.stop()
|
||||
time.sleep(5)
|
||||
|
||||
def setUp(self):
|
||||
"""Wait for spans to be drained before each test."""
|
||||
max_wait_seconds = 10
|
||||
check_interval = 0.2
|
||||
elapsed = 0
|
||||
consecutive_zero_count = 0
|
||||
required_consecutive_zeros = 3
|
||||
|
||||
while elapsed < max_wait_seconds:
|
||||
span_count = self.collector.count_spans()
|
||||
if span_count == 0:
|
||||
consecutive_zero_count += 1
|
||||
if consecutive_zero_count >= required_consecutive_zeros:
|
||||
break
|
||||
else:
|
||||
consecutive_zero_count = 0
|
||||
self.collector.clear()
|
||||
time.sleep(check_interval)
|
||||
elapsed += check_interval
|
||||
else:
|
||||
raise RuntimeError(
|
||||
f"Timeout waiting for spans to drain after {max_wait_seconds}s. "
|
||||
f"Remaining spans: {self.collector.count_spans()}"
|
||||
)
|
||||
|
||||
def test_disaggregation_transfer_spans(self):
|
||||
"""Test that disaggregation produces PREFILL_TRANSFER_KV_CACHE and DECODE_TRANSFERRED spans."""
|
||||
# Set trace level
|
||||
response = requests.get(f"{self.prefill_url}/set_trace_level?level=1")
|
||||
self.assertEqual(response.status_code, 200)
|
||||
response = requests.get(f"{self.decode_url}/set_trace_level?level=1")
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.collector.clear()
|
||||
|
||||
# Send a request through load balancer
|
||||
response = requests.post(
|
||||
f"{self.lb_url}/generate",
|
||||
json={
|
||||
"text": "The capital of France is",
|
||||
"sampling_params": {
|
||||
"temperature": 0,
|
||||
"max_new_tokens": 10,
|
||||
},
|
||||
"stream": False,
|
||||
},
|
||||
)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
# Wait for async export
|
||||
time.sleep(1)
|
||||
|
||||
# Verify spans were collected
|
||||
self.assertGreater(
|
||||
self.collector.count_spans(),
|
||||
0,
|
||||
"No spans collected from disaggregation request",
|
||||
)
|
||||
|
||||
# Verify disaggregation-specific spans exist
|
||||
span_names = self.collector.get_span_names()
|
||||
|
||||
# Check for transfer-related spans
|
||||
self.assertTrue(
|
||||
self.collector.has_any_span(
|
||||
[
|
||||
RequestStage.PREFILL_TRANSFER_KV_CACHE.stage_name,
|
||||
RequestStage.DECODE_TRANSFERRED.stage_name,
|
||||
]
|
||||
),
|
||||
f"Expected disaggregation transfer spans, got {sorted(span_names)}",
|
||||
)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Reference in New Issue
Block a user