[Kimi-K3] Merge fused_qkvg_proj into the loader-seeded packed_modules_mapping (#41164)

This commit is contained in:
Peng Wu
2026-09-28 16:46:11 +08:00
committed by GitHub
parent e8eeff2956
commit 546bfa7221
2 changed files with 70 additions and 1 deletions
+8 -1
View File
@@ -3109,7 +3109,14 @@ class KimiK3LinearForCausalLM(nn.Module):
}
quant_config.update_packed_modules_mapping({"model": model_mapping})
else:
quant_config.update_packed_modules_mapping(self.packed_modules_mapping)
# The loader seeded this mapping from the outer model class;
# replacing it would drop those entries.
quant_config.update_packed_modules_mapping(
{
**(quant_config.packed_modules_mapping or {}),
**self.packed_modules_mapping,
}
)
self.model = KimiK3LinearModel(
config, quant_config, prefix=maybe_prefix(prefix, "model")
)
@@ -0,0 +1,62 @@
"""KimiK3LinearForCausalLM must extend, not replace, the quant config's mapping."""
import unittest
from types import SimpleNamespace
from unittest.mock import patch
from sglang.srt.layers.quantization.modelopt_quant import ModelOptFp4Config
from sglang.srt.layers.quantization.utils import is_layer_skipped
from sglang.srt.models import kimi_k3
from sglang.srt.models.kimi_k3 import (
KimiK3ForConditionalGeneration,
KimiK3LinearForCausalLM,
)
from sglang.test.ci.ci_register import register_cpu_ci
from sglang.test.test_utils import CustomTestCase
register_cpu_ci(est_time=5, suite="base-a-test-cpu")
# Exclude lists name the checkpoint shards, not the fused runtime module.
EXCLUDE_MODULES = [f"model.layers.0.self_attn.{s}_conv1d" for s in "qkv"]
class TestKimiK3PackedModulesMapping(CustomTestCase):
def test_causal_lm_keeps_loader_seeded_mapping(self):
# The loader seeds the mapping from the registered outer model class.
quant_config = ModelOptFp4Config(
is_checkpoint_nvfp4_serialized=True,
group_size=16,
exclude_modules=EXCLUDE_MODULES,
packed_modules_mapping=dict(
KimiK3ForConditionalGeneration.packed_modules_mapping
),
)
with (
patch.object(kimi_k3, "KimiK3LinearModel"),
patch.object(kimi_k3, "get_parallel"),
patch.object(kimi_k3, "ParallelLMHead"),
patch.object(kimi_k3, "LogitsProcessor"),
):
KimiK3LinearForCausalLM(
SimpleNamespace(vocab_size=16, hidden_size=16), quant_config
)
self.assertEqual(
quant_config.packed_modules_mapping,
{
**KimiK3ForConditionalGeneration.packed_modules_mapping,
**KimiK3LinearForCausalLM.packed_modules_mapping,
},
)
self.assertTrue(
is_layer_skipped(
"model.layers.0.self_attn.qkv_conv1d",
quant_config.exclude_modules,
quant_config.packed_modules_mapping,
)
)
if __name__ == "__main__":
unittest.main()