Alison Shao
0c1e9bda57
mistral_common rejects an assistant turn carrying neither content nor tool calls, while other chat templates ignore it, so an OpenAI-compatible request that works elsewhere failed on Mistral models. Drop those turns before templating; turns with tool_calls, multimodal content, or real text are untouched, and a trailing assistant message is already consumed upstream as the continue_final_message prefix.
87 lines
2.4 KiB
Python
87 lines
2.4 KiB
Python
import unittest
|
|
|
|
from sglang.srt.utils.hf_transformers.mistral_utils import (
|
|
patch_mistral_common_tokenizer,
|
|
)
|
|
from sglang.test.ci.ci_register import register_cpu_ci
|
|
|
|
register_cpu_ci(est_time=3, suite="base-a-test-cpu")
|
|
|
|
|
|
def _user(text):
|
|
return {"role": "user", "content": text}
|
|
|
|
|
|
def _assistant(**fields):
|
|
return {"role": "assistant", **fields}
|
|
|
|
|
|
class _MistralCommonStub:
|
|
"""Stands in for MistralCommonBackend; the class name gates the patch."""
|
|
|
|
def __init__(self):
|
|
self.seen = None
|
|
self.chat_template = "x"
|
|
|
|
def apply_chat_template(self, messages, **kwargs):
|
|
self.seen = messages
|
|
return []
|
|
|
|
def add_special_tokens(self, *args, **kwargs):
|
|
return 0
|
|
|
|
def convert_tokens_to_ids(self, value):
|
|
return 0
|
|
|
|
def decode(self, *args, **kwargs):
|
|
return ""
|
|
|
|
def batch_decode(self, *args, **kwargs):
|
|
return []
|
|
|
|
|
|
class TestDropEmptyAssistantMessages(unittest.TestCase):
|
|
def _roles_passed_through(self, messages):
|
|
tokenizer = patch_mistral_common_tokenizer(_MistralCommonStub())
|
|
tokenizer.apply_chat_template(messages)
|
|
return [msg["role"] for msg in tokenizer.seen]
|
|
|
|
def test_empty_assistant_turn_is_dropped(self):
|
|
for content in ("", " ", None, [], [{"type": "text", "text": ""}]):
|
|
with self.subTest(content=content):
|
|
roles = self._roles_passed_through(
|
|
[_user("a"), _assistant(content=content), _user("b")]
|
|
)
|
|
|
|
self.assertEqual(roles, ["user", "user"])
|
|
|
|
def test_nonempty_assistant_turn_is_kept(self):
|
|
for content in (
|
|
"hi",
|
|
[{"type": "text", "text": "hi"}],
|
|
[
|
|
{"type": "text", "text": ""},
|
|
{"type": "image_url", "image_url": {"url": "https://x/y.png"}},
|
|
],
|
|
):
|
|
with self.subTest(content=content):
|
|
roles = self._roles_passed_through(
|
|
[_user("a"), _assistant(content=content), _user("b")]
|
|
)
|
|
|
|
self.assertEqual(roles, ["user", "assistant", "user"])
|
|
|
|
roles = self._roles_passed_through(
|
|
[
|
|
_user("a"),
|
|
_assistant(content="", tool_calls=[{"id": "call_1"}]),
|
|
_user("b"),
|
|
]
|
|
)
|
|
|
|
self.assertEqual(roles, ["user", "assistant", "user"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|