From ff89e0fe9a55cfab1233d4adcd752f9b918fd0e5 Mon Sep 17 00:00:00 2001 From: ziang663 <119752791+ziang663@users.noreply.github.com> Date: Fri, 26 Jun 2026 12:50:49 +0800 Subject: [PATCH] Fix KV event publisher bind conflict under PP (#29044) --- python/sglang/srt/managers/scheduler.py | 1 + .../srt/managers/scheduler_components/kv_events_publisher.py | 5 ++++- python/sglang/srt/observability/metrics_collector.py | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/python/sglang/srt/managers/scheduler.py b/python/sglang/srt/managers/scheduler.py index 1f4612868..5f3c85b65 100644 --- a/python/sglang/srt/managers/scheduler.py +++ b/python/sglang/srt/managers/scheduler.py @@ -454,6 +454,7 @@ class Scheduler( enable_metrics=self.server_args.enable_metrics, enable_kv_cache_events=bool( self.server_args.kv_events_config + and self.ps.pp_rank == 0 and self.ps.attn_tp_rank == 0 and self.ps.attn_cp_rank == 0 ), diff --git a/python/sglang/srt/managers/scheduler_components/kv_events_publisher.py b/python/sglang/srt/managers/scheduler_components/kv_events_publisher.py index 86e530ab9..e41538eb2 100644 --- a/python/sglang/srt/managers/scheduler_components/kv_events_publisher.py +++ b/python/sglang/srt/managers/scheduler_components/kv_events_publisher.py @@ -59,7 +59,10 @@ class SchedulerKvEventsPublisher: def init_kv_events(self, kv_events_config: Optional[str]): self.enable_kv_cache_events = bool( - kv_events_config and self.ps.attn_tp_rank == 0 and self.ps.attn_cp_rank == 0 + kv_events_config + and self.ps.pp_rank == 0 + and self.ps.attn_tp_rank == 0 + and self.ps.attn_cp_rank == 0 ) if self.enable_kv_cache_events: diff --git a/python/sglang/srt/observability/metrics_collector.py b/python/sglang/srt/observability/metrics_collector.py index f83020ee8..d1a9cca04 100644 --- a/python/sglang/srt/observability/metrics_collector.py +++ b/python/sglang/srt/observability/metrics_collector.py @@ -1044,6 +1044,7 @@ class SchedulerMetricsCollector(_StatLoggerDIMixin): ) enable_kv_cache_events = bool( server_args.kv_events_config + and ps.pp_rank == 0 and ps.attn_tp_rank == 0 and ps.attn_cp_rank == 0 )