move runs_on + rdma into runner_configs.yml (#25264)
This commit is contained in:
@@ -29,8 +29,8 @@ on:
|
||||
value: ${{ jobs.run.outputs.partitions }}
|
||||
partition_model_sha:
|
||||
value: ${{ jobs.run.outputs.partition_model_sha }}
|
||||
b200_runner:
|
||||
value: ${{ jobs.run.outputs.b200_runner }}
|
||||
runs_on_map:
|
||||
value: ${{ jobs.run.outputs.runs_on_map }}
|
||||
enable_retry:
|
||||
value: ${{ jobs.run.outputs.enable_retry }}
|
||||
continue_on_error:
|
||||
@@ -47,7 +47,7 @@ jobs:
|
||||
multimodal_gen: ${{ steps.filter.outputs.multimodal_gen || steps.run-mode.outputs.run_all_tests }}
|
||||
partitions: ${{ steps.partitions.outputs.partitions }}
|
||||
partition_model_sha: ${{ steps.partition-model-sha.outputs.sha }}
|
||||
b200_runner: ${{ steps.set-runner.outputs.b200_runner }}
|
||||
runs_on_map: ${{ steps.runner-map.outputs.runs_on_map }}
|
||||
enable_retry: ${{ steps.set-retry.outputs.enable_retry }}
|
||||
continue_on_error: ${{ steps.set-continue-on-error.outputs.continue_on_error }}
|
||||
steps:
|
||||
@@ -174,6 +174,13 @@ jobs:
|
||||
echo "b200_runner=4-gpu-b200" >> $GITHUB_OUTPUT
|
||||
fi
|
||||
|
||||
- name: Build runs_on_map (resolves $b200_runner sentinel)
|
||||
id: runner-map
|
||||
run: |
|
||||
python3 scripts/ci/runner_configs.py --map \
|
||||
'${{ steps.set-runner.outputs.b200_runner }}' \
|
||||
>> "$GITHUB_OUTPUT"
|
||||
|
||||
- name: Enable retry for CI
|
||||
id: set-retry
|
||||
run: |
|
||||
|
||||
@@ -15,15 +15,11 @@ on:
|
||||
type: string
|
||||
required: true
|
||||
runner_config:
|
||||
description: 'Key in scripts/ci/runner_configs.yml (install script / artifact version / install timeout).'
|
||||
type: string
|
||||
required: true
|
||||
runs_on:
|
||||
description: 'GHA runner label. B200 stages pass needs.check-changes.outputs.b200_runner for dynamic selection.'
|
||||
description: 'Key in scripts/ci/runner_configs.yml. Resolves install script, artifact version, install timeout, runs-on label, and rdma_devices.'
|
||||
type: string
|
||||
required: true
|
||||
check_changes:
|
||||
description: 'toJson(needs.check-changes.outputs). Read via fromJson(...).main_package / sgl_kernel / continue_on_error etc.'
|
||||
description: 'toJson(needs.check-changes.outputs). Read via fromJson(...).main_package / sgl_kernel / continue_on_error / runs_on_map etc.'
|
||||
type: string
|
||||
required: true
|
||||
caller_inputs:
|
||||
@@ -79,11 +75,11 @@ jobs:
|
||||
always() &&
|
||||
((github.event_name == 'schedule' || fromJson(inputs.caller_inputs).test_parallel_dispatch == true) || (!failure() && !cancelled())) &&
|
||||
(fromJson(inputs.check_changes).main_package == 'true' || fromJson(inputs.check_changes).sgl_kernel == 'true')
|
||||
runs-on: ${{ inputs.runs_on }}
|
||||
# runs-on resolved from runs_on_map; check-changes already substituted
|
||||
# $b200_runner (see runner_configs.py --map). rdma_devices is exported
|
||||
# below in a setup step via $GITHUB_ENV.
|
||||
runs-on: ${{ fromJson(fromJson(inputs.check_changes).runs_on_map)[inputs.runner_config] }}
|
||||
timeout-minutes: 240
|
||||
env:
|
||||
# Only stage-c-test-8-gpu-h20 needs the RDMA device list.
|
||||
SGLANG_CI_RDMA_ALL_DEVICES: ${{ inputs.runner_config == '8-gpu-h20' && 'mlx5_1,mlx5_2,mlx5_3,mlx5_4' || '' }}
|
||||
strategy:
|
||||
fail-fast: false
|
||||
max-parallel: ${{ fromJson(inputs.partitions)[inputs.self_name].max_parallel }}
|
||||
@@ -98,6 +94,9 @@ jobs:
|
||||
id: rc
|
||||
run: python3 scripts/ci/runner_configs.py '${{ inputs.runner_config }}' >> "$GITHUB_OUTPUT"
|
||||
|
||||
- name: Export rdma_devices to job env
|
||||
run: echo "SGLANG_CI_RDMA_ALL_DEVICES=${{ steps.rc.outputs.rdma_devices || '' }}" >> "$GITHUB_ENV"
|
||||
|
||||
- uses: ./.github/actions/check-stage-health
|
||||
|
||||
- uses: ./.github/actions/check-maintenance
|
||||
|
||||
@@ -107,7 +107,6 @@ jobs:
|
||||
with:
|
||||
self_name: extra-a-test-1-gpu-small
|
||||
runner_config: 1-gpu-small
|
||||
runs_on: 1-gpu-5090
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -121,7 +120,6 @@ jobs:
|
||||
with:
|
||||
self_name: extra-a-test-1-gpu-large
|
||||
runner_config: 1-gpu-large
|
||||
runs_on: 1-gpu-h100
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -136,7 +134,6 @@ jobs:
|
||||
with:
|
||||
self_name: extra-a-test-2-gpu-large
|
||||
runner_config: 2-gpu-large
|
||||
runs_on: 2-gpu-h100
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -151,7 +148,6 @@ jobs:
|
||||
with:
|
||||
self_name: extra-b-test-4-gpu-h100
|
||||
runner_config: 4-gpu-h100
|
||||
runs_on: 4-gpu-h100
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -165,7 +161,6 @@ jobs:
|
||||
with:
|
||||
self_name: extra-b-test-4-gpu-b200
|
||||
runner_config: 4-gpu-b200
|
||||
runs_on: ${{ needs.check-changes.outputs.b200_runner }}
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -180,7 +175,6 @@ jobs:
|
||||
with:
|
||||
self_name: extra-b-test-8-gpu-h200
|
||||
runner_config: 8-gpu-h200
|
||||
runs_on: 8-gpu-h200
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -194,7 +188,6 @@ jobs:
|
||||
with:
|
||||
self_name: extra-b-test-deepep-8-gpu-h200
|
||||
runner_config: deepep-8-gpu-h200
|
||||
runs_on: 8-gpu-h200-deepep
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
|
||||
@@ -9,7 +9,10 @@ on:
|
||||
sgl_kernel:
|
||||
required: true
|
||||
type: string
|
||||
b200_runner:
|
||||
runner_config:
|
||||
required: true
|
||||
type: string
|
||||
runs_on_map:
|
||||
required: true
|
||||
type: string
|
||||
git_ref:
|
||||
@@ -157,7 +160,7 @@ jobs:
|
||||
if: |
|
||||
github.event_name != 'schedule' &&
|
||||
inputs.test_parallel_dispatch != 'true'
|
||||
runs-on: ${{ inputs.b200_runner }}
|
||||
runs-on: ${{ fromJson(inputs.runs_on_map)[inputs.runner_config] }}
|
||||
timeout-minutes: 240
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
|
||||
@@ -9,7 +9,10 @@ on:
|
||||
sgl_kernel:
|
||||
required: true
|
||||
type: string
|
||||
b200_runner:
|
||||
runner_config:
|
||||
required: true
|
||||
type: string
|
||||
runs_on_map:
|
||||
required: true
|
||||
type: string
|
||||
continue_on_error:
|
||||
@@ -264,7 +267,7 @@ jobs:
|
||||
if: |
|
||||
((github.event_name == 'schedule' || inputs.test_parallel_dispatch == 'true') || (inputs.caller_needs_failure != 'true' && !cancelled())) &&
|
||||
inputs.multimodal_gen == 'true'
|
||||
runs-on: ${{ inputs.b200_runner }}
|
||||
runs-on: ${{ fromJson(inputs.runs_on_map)[inputs.runner_config] }}
|
||||
timeout-minutes: 240
|
||||
steps:
|
||||
- name: Checkout code
|
||||
|
||||
@@ -6,7 +6,10 @@ on:
|
||||
sgl_kernel:
|
||||
required: true
|
||||
type: string
|
||||
b200_runner:
|
||||
runner_config:
|
||||
required: true
|
||||
type: string
|
||||
runs_on_map:
|
||||
required: true
|
||||
type: string
|
||||
git_ref:
|
||||
@@ -110,7 +113,7 @@ jobs:
|
||||
echo "All benchmark tests completed!"
|
||||
|
||||
sgl-kernel-b200-test:
|
||||
runs-on: ${{ inputs.b200_runner }}
|
||||
runs-on: ${{ fromJson(inputs.runs_on_map)[inputs.runner_config] }}
|
||||
timeout-minutes: 240
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
|
||||
@@ -209,8 +209,9 @@ jobs:
|
||||
needs.check-changes.outputs.sgl_kernel == 'true'
|
||||
uses: ./.github/workflows/pr-test-sgl-kernel.yml
|
||||
with:
|
||||
runner_config: 4-gpu-b200
|
||||
runs_on_map: ${{ needs.check-changes.outputs.runs_on_map }}
|
||||
sgl_kernel: ${{ needs.check-changes.outputs.sgl_kernel }}
|
||||
b200_runner: ${{ needs.check-changes.outputs.b200_runner }}
|
||||
git_ref: ${{ inputs.git_ref || '' }}
|
||||
skip_stage_health_check: ${{ inputs.skip_stage_health_check == true }}
|
||||
secrets: inherit
|
||||
@@ -227,9 +228,10 @@ jobs:
|
||||
needs.check-changes.outputs.jit_kernel == 'true'
|
||||
uses: ./.github/workflows/pr-test-jit-kernel.yml
|
||||
with:
|
||||
runner_config: 4-gpu-b200
|
||||
runs_on_map: ${{ needs.check-changes.outputs.runs_on_map }}
|
||||
jit_kernel: ${{ needs.check-changes.outputs.jit_kernel }}
|
||||
sgl_kernel: ${{ needs.check-changes.outputs.sgl_kernel }}
|
||||
b200_runner: ${{ needs.check-changes.outputs.b200_runner }}
|
||||
git_ref: ${{ inputs.git_ref || '' }}
|
||||
test_parallel_dispatch: ${{ inputs.test_parallel_dispatch == true && 'true' || 'false' }}
|
||||
skip_stage_health_check: ${{ inputs.skip_stage_health_check == true }}
|
||||
@@ -245,7 +247,6 @@ jobs:
|
||||
with:
|
||||
self_name: stage-a-test-1-gpu-small
|
||||
runner_config: 1-gpu-small
|
||||
runs_on: 1-gpu-5090
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -325,7 +326,6 @@ jobs:
|
||||
with:
|
||||
self_name: stage-b-test-1-gpu-small
|
||||
runner_config: 1-gpu-small
|
||||
runs_on: 1-gpu-5090
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -340,7 +340,6 @@ jobs:
|
||||
with:
|
||||
self_name: stage-b-test-1-gpu-large
|
||||
runner_config: 1-gpu-large
|
||||
runs_on: 1-gpu-h100
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -355,7 +354,6 @@ jobs:
|
||||
with:
|
||||
self_name: stage-b-test-2-gpu-large
|
||||
runner_config: 2-gpu-large
|
||||
runs_on: 2-gpu-h100
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -369,7 +367,6 @@ jobs:
|
||||
with:
|
||||
self_name: stage-b-test-4-gpu-b200
|
||||
runner_config: 4-gpu-b200
|
||||
runs_on: ${{ needs.check-changes.outputs.b200_runner }}
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -386,9 +383,10 @@ jobs:
|
||||
needs.check-changes.outputs.multimodal_gen == 'true'
|
||||
uses: ./.github/workflows/pr-test-multimodal-gen.yml
|
||||
with:
|
||||
runner_config: 4-gpu-b200
|
||||
runs_on_map: ${{ needs.check-changes.outputs.runs_on_map }}
|
||||
multimodal_gen: ${{ needs.check-changes.outputs.multimodal_gen }}
|
||||
sgl_kernel: ${{ needs.check-changes.outputs.sgl_kernel }}
|
||||
b200_runner: ${{ needs.check-changes.outputs.b200_runner }}
|
||||
continue_on_error: ${{ needs.check-changes.outputs.continue_on_error }}
|
||||
git_ref: ${{ inputs.git_ref || '' }}
|
||||
test_parallel_dispatch: ${{ inputs.test_parallel_dispatch == true && 'true' || 'false' }}
|
||||
@@ -403,7 +401,6 @@ jobs:
|
||||
with:
|
||||
self_name: stage-c-test-4-gpu-h100
|
||||
runner_config: 4-gpu-h100
|
||||
runs_on: 4-gpu-h100
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -417,7 +414,6 @@ jobs:
|
||||
with:
|
||||
self_name: stage-c-test-8-gpu-h200
|
||||
runner_config: 8-gpu-h200
|
||||
runs_on: 8-gpu-h200
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -438,7 +434,6 @@ jobs:
|
||||
with:
|
||||
self_name: stage-c-test-8-gpu-h20
|
||||
runner_config: 8-gpu-h20
|
||||
runs_on: 8-gpu-h20
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -452,7 +447,6 @@ jobs:
|
||||
with:
|
||||
self_name: stage-c-test-deepep-4-gpu-h100
|
||||
runner_config: deepep-4-gpu-h100
|
||||
runs_on: 4-gpu-h100
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -468,7 +462,6 @@ jobs:
|
||||
with:
|
||||
self_name: stage-c-test-4-gpu-b200
|
||||
runner_config: 4-gpu-b200
|
||||
runs_on: ${{ needs.check-changes.outputs.b200_runner }}
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -483,7 +476,6 @@ jobs:
|
||||
with:
|
||||
self_name: stage-c-test-dsv4-4-gpu-b200
|
||||
runner_config: dsv4-4-gpu-b200
|
||||
runs_on: ${{ needs.check-changes.outputs.b200_runner }}
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
@@ -498,7 +490,6 @@ jobs:
|
||||
with:
|
||||
self_name: stage-c-test-dsv4-8-gpu-h200
|
||||
runner_config: dsv4-8-gpu-h200
|
||||
runs_on: 8-gpu-h200
|
||||
check_changes: ${{ toJson(needs.check-changes.outputs) }}
|
||||
caller_inputs: ${{ toJson(inputs) }}
|
||||
partitions: ${{ needs.check-changes.outputs.partitions }}
|
||||
|
||||
Reference in New Issue
Block a user