minke.yu/sglang
1
0
Fork 0
Code Issues Pull Requests Actions 12 Packages Projects Releases Wiki Activity

fix(openai): map reasoning.enabled to thinking AND enable_thinking (#23951)

Browse Source
This commit is contained in:
Xinyuan Tong
2026-05-07 14:01:35 -07:00
committed by GitHub
parent 9cffa5ed6f
commit f1395af543
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/sglang/srt/entrypoints/openai/protocol.py
+4
View File
@@ -721,7 +721,11 @@ class ChatCompletionRequest(BaseModel):
ctk = values.get("chat_template_kwargs") ctk = values.get("chat_template_kwargs")
if not isinstance(ctk, dict): if not isinstance(ctk, dict):
ctk = {} ctk = {}
# different models check different keys:
# - "thinking" for deepseek-v3, kimi_k2
# - "enable_thinking" for qwen3, glm45, nemotron_3, interns1, mimo
ctk.setdefault("thinking", True) ctk.setdefault("thinking", True)
ctk.setdefault("enable_thinking", True)
values["chat_template_kwargs"] = ctk values["chat_template_kwargs"] = ctk
if values.get("reasoning_effort") == "none": if values.get("reasoning_effort") == "none":
test/registered/unit/entrypoints/openai/test_protocol.py
+4 -1
View File
@@ -191,7 +191,10 @@ class TestChatCompletionRequest(unittest.TestCase):
}, },
) )
self.assertEqual(request.reasoning_effort, "high") self.assertEqual(request.reasoning_effort, "high")
self.assertEqual(request.chat_template_kwargs, {"thinking": True}) self.assertEqual(
request.chat_template_kwargs,
{"thinking": True, "enable_thinking": True},
)
def test_chat_completion_reasoning_effort_none(self): def test_chat_completion_reasoning_effort_none(self):
"""Test reasoning_effort='none' disables thinking""" """Test reasoning_effort='none' disables thinking"""