throw ValueError for DoRA adapters (#22125)

Co-authored-by: Ethan (Yusheng) Su <yushengsu.thu@gmail.com>
This commit is contained in:
Glen Liu
2026-05-02 14:54:19 +00:00
committed by GitHub
co-authored by Ethan Su
parent 4128f1ffe2
commit e0474fdd9b
2 changed files with 7 additions and 8 deletions
+1 -7
View File
@@ -42,6 +42,7 @@ class LoRAConfig:
self.target_modules = self.hf_config["target_modules"]
self.r = self.hf_config["r"]
self.lora_alpha = self.hf_config["lora_alpha"]
self.use_dora = self.hf_config.get("use_dora", False)
# Filter fake added tokens: tokens with ID < base_vocab_size are already
# part of the base vocabulary and should not be treated as added tokens.
@@ -58,13 +59,6 @@ class LoRAConfig:
len(self.added_tokens_config) if self.added_tokens_config is not None else 0
)
if self.lora_added_tokens_size > 0:
raise ValueError(
f"LoRA adapter has {self.lora_added_tokens_size} added tokens, "
f"but added tokens are not supported yet. "
f"Added tokens: {self.added_tokens_config}"
)
@classmethod
def from_dict(
cls,
+6 -1
View File
@@ -191,7 +191,12 @@ class LoRAManager:
"""
if lora_config.lora_added_tokens_size > 0:
raise ValueError(
f"LoRA serving currently doesn't support adapters that add tokens to the vocabulary"
f"Failed to load {lora_ref.lora_name} because LoRA serving currently doesn't support adapters that add tokens to the vocabulary"
)
if lora_config.use_dora:
raise ValueError(
f"Failed to load {lora_ref.lora_name} because LoRA serving currently doesn't support DoRA adapters"
)
# Check if this LoRA adapter is already loaded