From d5e707f1327e29db1e84ee31b17faac53af728bb Mon Sep 17 00:00:00 2001 From: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com> Date: Mon, 11 May 2026 13:00:08 +0800 Subject: [PATCH] Fix sgl-kernel-mla-test path after test was moved to test/manual (#24914) Co-authored-by: Alison Shao Co-authored-by: Alison Shao <54658187+alisonshao@users.noreply.github.com> --- .github/workflows/pr-test-sgl-kernel.yml | 35 ------------------------ .github/workflows/pr-test.yml | 13 +++++++-- 2 files changed, 11 insertions(+), 37 deletions(-) diff --git a/.github/workflows/pr-test-sgl-kernel.yml b/.github/workflows/pr-test-sgl-kernel.yml index bb69b89ac..2a49d2a3c 100644 --- a/.github/workflows/pr-test-sgl-kernel.yml +++ b/.github/workflows/pr-test-sgl-kernel.yml @@ -66,41 +66,6 @@ jobs: cd sgl-kernel pytest tests/ - sgl-kernel-mla-test: - runs-on: 1-gpu-h100 - timeout-minutes: 240 - steps: - - uses: actions/checkout@v4 - with: - ref: ${{ inputs.pr_head_sha || inputs.git_ref || github.sha }} - - - uses: ./.github/actions/check-stage-health - - - uses: ./.github/actions/check-maintenance - - - name: Cleanup - run: | - ls -alh sgl-kernel/dist || true - rm -rf sgl-kernel/dist/* || true - - - name: Download artifacts - uses: actions/download-artifact@v4 - with: - path: sgl-kernel/dist/ - merge-multiple: true - pattern: wheel-python3.10-cuda* - - - name: Install dependencies - timeout-minutes: 20 - run: | - CUSTOM_BUILD_SGL_KERNEL=${{inputs.sgl_kernel}} bash scripts/ci/cuda/ci_install_dependency.sh - - - name: Run test - timeout-minutes: 30 - run: | - cd test/registered/mla - python3 test_mla_deepseek_v3.py - sgl-kernel-benchmark-test: runs-on: 1-gpu-h100 timeout-minutes: 240 diff --git a/.github/workflows/pr-test.yml b/.github/workflows/pr-test.yml index 01cf68690..8fb97d36a 100644 --- a/.github/workflows/pr-test.yml +++ b/.github/workflows/pr-test.yml @@ -158,7 +158,8 @@ jobs: - "python/pyproject.toml" - "python/sglang/jit_kernel/**" sgl_kernel: - - ".github/workflows/pr-test-sgl-kernel.yml" + # Intentionally excludes ".github/workflows/pr-test-sgl-kernel.yml" — + # see API-side detector below for rationale. - "sgl-kernel/**/!(*.md|THIRDPARTYNOTICES.txt|LICENSE)" # For /rerun-stage (workflow_dispatch with target_stage), dorny/paths-filter doesn't work @@ -192,7 +193,15 @@ jobs: echo "..." # Check for sgl-kernel changes - if echo "$CHANGED_FILES" | grep -qE "^(sgl-kernel/|\.github/workflows/pr-test-sgl-kernel\.yml)"; then + # Note: edits to .github/workflows/pr-test-sgl-kernel.yml are intentionally + # NOT considered sgl-kernel changes. That filter line used to be included + # so workflow refactors got retested, but in practice it only catches the + # workflow's *consumers* (test job definitions), not the wheel build steps + # themselves — and gating sgl_kernel=true on it forces a 20-30 min wheel + # rebuild + the stage-a-test-1-gpu-small gate for pure CI-yaml edits that + # can't actually affect kernel behavior. PRs that touch wheel-build logic + # in scripts/ci/cuda/ or sgl-kernel/ still trigger correctly. + if echo "$CHANGED_FILES" | grep -qE "^sgl-kernel/"; then echo "sgl_kernel=true" >> $GITHUB_OUTPUT echo "Detected sgl-kernel changes" else