[diffusion] UX: suppress excessive loggers (#14900)

This commit is contained in:
Mick
2025-12-11 22:10:22 +08:00
committed by GitHub
parent 543d62d11a
commit ca1144212a
3 changed files with 58 additions and 26 deletions
@@ -19,15 +19,12 @@
"""Utilities for Huggingface Transformers."""
import contextlib
import hashlib
import json
import os
import tempfile
from functools import reduce
from pathlib import Path
from typing import Any, Optional, cast
import filelock
from diffusers.loaders.lora_base import (
_best_guess_weight_name, # watch out for potetential removal from diffusers
)
@@ -35,6 +32,7 @@ from huggingface_hub import snapshot_download
from transformers import AutoConfig, PretrainedConfig
from transformers.models.auto.modeling_auto import MODEL_FOR_CAUSAL_LM_MAPPING_NAMES
from sglang.multimodal_gen.runtime.loader.weight_utils import get_lock
from sglang.multimodal_gen.runtime.utils.logging_utils import (
init_logger,
suppress_other_loggers,
@@ -200,18 +198,6 @@ def check_gguf_file(model: str | os.PathLike) -> bool:
return header == b"GGUF"
def get_lock(model_name_or_path: str):
lock_dir = tempfile.gettempdir()
os.makedirs(os.path.dirname(lock_dir), exist_ok=True)
model_name = model_name_or_path.replace("/", "-")
hash_name = hashlib.sha256(model_name.encode()).hexdigest()
# add hash to avoid conflict with old users' lock files
lock_file_name = hash_name + model_name + ".lock"
# mode 0o666 is required for the filelock to be shared across users
lock = filelock.FileLock(os.path.join(lock_dir, lock_file_name), mode=0o666)
return lock
def maybe_download_lora(
model_name_or_path: str, local_dir: str | None = None, download: bool = True
) -> str:
@@ -391,15 +377,15 @@ def maybe_download_model(
"Downloading model snapshot from HF Hub for %s...", model_name_or_path
)
with (
suppress_other_loggers(not_suppress_on_main_rank=False),
get_lock(model_name_or_path).acquire(poll_interval=2),
suppress_other_loggers(not_suppress_on_main_rank=True),
):
local_path = snapshot_download(
repo_id=model_name_or_path,
ignore_patterns=["*.onnx", "*.msgpack"],
local_dir=local_dir,
)
logger.info("Downloaded model to %s", local_path)
logger.info("Downloaded model to %s", local_path)
return str(local_path)
except Exception as e:
raise ValueError(