minke.yu/sglang
1
0
Fork 0
Code Issues Pull Requests Actions 12 Packages Projects Releases Wiki Activity

[Minor] Change lora_target_modules to "all" in CI tests (#17386)

Browse Source
This commit is contained in:
Baizhou Zhang
2026-01-21 11:46:36 +08:00
committed by GitHub
parent 54a821794e
commit c3f9c30f99
3 changed files with 7 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/registered/lora/test_lora_eviction.py
+1 -11
View File
@@ -101,17 +101,7 @@ class TestLoRAEviction(CustomTestCase):
max_loras_per_batch=1, max_loras_per_batch=1,
enable_lora=True, enable_lora=True,
max_lora_rank=256, max_lora_rank=256,
# Need to list all lora modules, or "all" might include lora modules without assigning lora weights lora_target_modules=["all"],
# lora_target_modules=["all"],
lora_target_modules=[
"q_proj",
"k_proj",
"v_proj",
"o_proj",
"gate_proj",
"up_proj",
"down_proj",
],
) as srt_runner: ) as srt_runner:
adapter_sequence = lora_paths if not reverse else lora_paths[::-1] adapter_sequence = lora_paths if not reverse else lora_paths[::-1]
test/registered/lora/test_lora_update.py
+4 -44
View File
@@ -221,17 +221,7 @@ BASIC_TESTS = [
base="meta-llama/Llama-3.1-8B-Instruct", base="meta-llama/Llama-3.1-8B-Instruct",
enable_lora=True, enable_lora=True,
max_lora_rank=256, max_lora_rank=256,
# Need to list all lora modules, or "all" might include lora modules without assigning lora weights lora_target_modules=["all"],
# lora_target_modules=["all"],
lora_target_modules=[
"q_proj",
"k_proj",
"v_proj",
"o_proj",
"gate_proj",
"up_proj",
"down_proj",
],
max_loras_per_batch=4, max_loras_per_batch=4,
all_adapters=[ all_adapters=[
"philschmid/code-llama-3-1-8b-text-to-sql-lora", "philschmid/code-llama-3-1-8b-text-to-sql-lora",
@@ -350,17 +340,7 @@ TARGET_MODULE_TESTS = [
description="Test explicitly specified lora-target-modules.", description="Test explicitly specified lora-target-modules.",
base="meta-llama/Llama-3.1-8B-Instruct", base="meta-llama/Llama-3.1-8B-Instruct",
max_loras_per_batch=3, max_loras_per_batch=3,
# Need to list all lora modules, or "all" might include lora modules without assigning lora weights lora_target_modules=["all"],
# lora_target_modules=["all"],
lora_target_modules=[
"q_proj",
"k_proj",
"v_proj",
"o_proj",
"gate_proj",
"up_proj",
"down_proj",
],
max_lora_rank=64, max_lora_rank=64,
all_adapters=[ all_adapters=[
"Nutanix/Meta-Llama-3.1-8B-Instruct_lora_4_alpha_16", # target_modules = q, k, v, o, gate, up, down "Nutanix/Meta-Llama-3.1-8B-Instruct_lora_4_alpha_16", # target_modules = q, k, v, o, gate, up, down
@@ -766,17 +746,7 @@ EVICTION_TESTS = [
], ],
enable_lora=True, enable_lora=True,
max_lora_rank=256, max_lora_rank=256,
# Need to list all lora modules, or "all" might include lora modules without assigning lora weights lora_target_modules=["all"],
# lora_target_modules=["all"],
lora_target_modules=[
"q_proj",
"k_proj",
"v_proj",
"o_proj",
"gate_proj",
"up_proj",
"down_proj",
],
op_sequence=[ op_sequence=[
Operation( Operation(
type=OperationType.LOAD, type=OperationType.LOAD,
@@ -1528,17 +1498,7 @@ class TestLoRADynamicUpdate(CustomTestCase):
lora_paths=[], lora_paths=[],
max_loras_per_batch=2, max_loras_per_batch=2,
max_lora_rank=256, max_lora_rank=256,
# Need to list all lora modules, or "all" might include lora modules without assigning lora weights lora_target_modules=["all"],
# lora_target_modules=["all"],
lora_target_modules=[
"q_proj",
"k_proj",
"v_proj",
"o_proj",
"gate_proj",
"up_proj",
"down_proj",
],
enable_lora=True, enable_lora=True,
) as session: ) as session:
# Test with no adapters loaded # Test with no adapters loaded
test/registered/rl/test_lora_load_from_tensor.py
+2 -18
View File
@@ -29,15 +29,7 @@ class TestLoRALoadFromTensor(CustomTestCase):
model_path=MODEL_PATH, model_path=MODEL_PATH,
enable_lora=True, enable_lora=True,
max_lora_rank=64, max_lora_rank=64,
lora_target_modules=[ lora_target_modules=["all"],
"q_proj",
"k_proj",
"v_proj",
"o_proj",
"gate_proj",
"up_proj",
"down_proj",
],
mem_fraction_static=0.6, mem_fraction_static=0.6,
log_level="error", log_level="error",
) )
@@ -61,15 +53,7 @@ class TestLoRALoadFromTensor(CustomTestCase):
model_path=MODEL_PATH, model_path=MODEL_PATH,
enable_lora=True, enable_lora=True,
max_lora_rank=64, max_lora_rank=64,
lora_target_modules=[ lora_target_modules=["all"],
"q_proj",
"k_proj",
"v_proj",
"o_proj",
"gate_proj",
"up_proj",
"down_proj",
],
mem_fraction_static=0.6, mem_fraction_static=0.6,
log_level="error", log_level="error",
max_loaded_loras=MAX_LOADED_LORAS, max_loaded_loras=MAX_LOADED_LORAS,