From a8759dd9af058bfa0fc4a87f7ec338b6b4792e14 Mon Sep 17 00:00:00 2001 From: Liangsheng Yin Date: Tue, 31 Mar 2026 17:40:58 -0700 Subject: [PATCH] Fix killall.py crash when sglang is not yet installed (#21797) --- python/sglang/cli/killall.py | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/python/sglang/cli/killall.py b/python/sglang/cli/killall.py index 1c886e1eb..629284e5b 100755 --- a/python/sglang/cli/killall.py +++ b/python/sglang/cli/killall.py @@ -78,9 +78,23 @@ def _run_smi(query, query_type="gpu"): def _get_smi_version(): """Return nvidia-smi driver version and GPU name, or None on failure.""" - from sglang.srt.utils.common import get_nvidia_driver_version_str - - driver = get_nvidia_driver_version_str() + # Inline nvidia-smi query — killall.py runs before pip install, so sglang + # internals may not be importable. + try: + result = subprocess.run( + [ + "nvidia-smi", + "--query-gpu=driver_version", + "--format=csv,noheader,nounits", + ], + capture_output=True, + text=True, + check=True, + timeout=10, + ) + driver = result.stdout.strip().split("\n")[0].strip() or None + except (subprocess.SubprocessError, FileNotFoundError): + driver = None if driver is None: return None try: