From a34cba3c62ff9c0a3e89df9bb25943844804c6ba Mon Sep 17 00:00:00 2001 From: metamergebot Date: Tue, 6 Oct 2026 11:02:23 -0700 Subject: [PATCH] [HiCache] Resolve write_back to write_through under buffer_only host memory (#42754) Co-authored-by: merrymercy Co-authored-by: xiezhq-hermann --- python/sglang/srt/arg_groups/hicache_hook.py | 13 +++++++--- .../unit/server_args/test_server_args.py | 26 +++++++++++++++++++ 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/python/sglang/srt/arg_groups/hicache_hook.py b/python/sglang/srt/arg_groups/hicache_hook.py index 457f6a0428..901fa2b14d 100644 --- a/python/sglang/srt/arg_groups/hicache_hook.py +++ b/python/sglang/srt/arg_groups/hicache_hook.py @@ -235,10 +235,15 @@ def validate_hicache_host_memory_mode(server_args: Any): "and all cached data lives in storage." ) if cfg.hicache_write_policy == "write_back": - raise ValueError( - "--hicache-host-memory-mode buffer_only does not support " - "--hicache-write-policy write_back; use write_through or " - "write_through_selective." + # buffer_only has no host tier to write back to; pages go to storage. + declare_resolution( + server_args, + "_validate_hicache_host_memory_mode", + hicache_write_policy="write_through", + ) + logger.info( + "--hicache-host-memory-mode buffer_only resolves " + "--hicache-write-policy write_back to write_through" ) if cfg.disaggregation_mode == "decode": raise ValueError( diff --git a/test/registered/unit/server_args/test_server_args.py b/test/registered/unit/server_args/test_server_args.py index 0d26063d56..d94dbf3f68 100644 --- a/test/registered/unit/server_args/test_server_args.py +++ b/test/registered/unit/server_args/test_server_args.py @@ -2088,6 +2088,32 @@ class TestHiCacheArgs(CustomTestCase): with envs.SGLANG_UNIFIED_RADIX_TREE_CORE_BACKEND.override(backend): handle_hicache(args) + def test_buffer_only_resolves_write_back_to_write_through(self): + """buffer_only has no retained host tier for write_back to defer + writes into, so the mode resolves that policy to write_through + instead of rejecting the launch. The rewrite is that narrow: an + explicit write_through_selective stays as given, and the cache + mode keeps write_back. + """ + cases = [ + ("buffer_only", "write_back", "write_through"), + ("buffer_only", "write_through", "write_through"), + ("buffer_only", "write_through_selective", "write_through_selective"), + ("cache", "write_back", "write_back"), + ] + for mode, policy, expected in cases: + with self.subTest(mode=mode, policy=policy): + args = self._make_args( + enable_hierarchical_cache=True, + hicache_host_memory_mode=mode, + hicache_storage_backend="file", + hicache_write_policy=policy, + ) + handle_hicache(args) + self.assertEqual( + resolution_result(args, "hicache_write_policy"), expected + ) + def test_optimistic_prefill_allows_only_exercised_hicache_modes(self): common = { "enable_hierarchical_cache": True,