[HiCache] fix: Clone host indices to avoid memory leak (#21624)
Co-authored-by: Zhiqiang Xie <xiezhq@stanford.edu>
This commit is contained in:
@@ -296,7 +296,7 @@ class HiMambaRadixCache(MambaRadixCache):
|
|||||||
extra_pools=extra_pools,
|
extra_pools=extra_pools,
|
||||||
)
|
)
|
||||||
if host_indices is not None:
|
if host_indices is not None:
|
||||||
node.host_value = host_indices
|
node.host_value = host_indices.clone()
|
||||||
if extra_pools is not None:
|
if extra_pools is not None:
|
||||||
self.mamba_backup_commit(node, extra_pools)
|
self.mamba_backup_commit(node, extra_pools)
|
||||||
assert len(node.host_value) > 0
|
assert len(node.host_value) > 0
|
||||||
@@ -2044,7 +2044,7 @@ class HiMambaRadixCache(MambaRadixCache):
|
|||||||
return
|
return
|
||||||
host_indices = transfers[0].host_indices
|
host_indices = transfers[0].host_indices
|
||||||
if node.mamba_host_value is None and host_indices is not None:
|
if node.mamba_host_value is None and host_indices is not None:
|
||||||
node.mamba_host_value = host_indices
|
node.mamba_host_value = host_indices.clone()
|
||||||
self.mamba_host_lru_list.insert_mru(node)
|
self.mamba_host_lru_list.insert_mru(node)
|
||||||
|
|
||||||
def mamba_archive_transfers(self, node: TreeNode) -> Optional[list[PoolTransfer]]:
|
def mamba_archive_transfers(self, node: TreeNode) -> Optional[list[PoolTransfer]]:
|
||||||
|
|||||||
@@ -619,7 +619,7 @@ class HiRadixCache(RadixCache):
|
|||||||
node_id=node.id,
|
node_id=node.id,
|
||||||
)
|
)
|
||||||
if host_indices is not None:
|
if host_indices is not None:
|
||||||
node.host_value = host_indices
|
node.host_value = host_indices.clone()
|
||||||
assert len(node.host_value) > 0
|
assert len(node.host_value) > 0
|
||||||
self.ongoing_write_through[node.id] = node
|
self.ongoing_write_through[node.id] = node
|
||||||
if not write_back:
|
if not write_back:
|
||||||
|
|||||||
Reference in New Issue
Block a user