From 8905cbd42f4a27dbecad6487cd3904278756fef8 Mon Sep 17 00:00:00 2001 From: zijiexia <37504505+zijiexia@users.noreply.github.com> Date: Mon, 20 Jul 2026 16:14:12 -0700 Subject: [PATCH] Fix MiniMax-M3 crash on ROCm by making its override fields resolvable (#31837) --- python/sglang/srt/server_args.py | 10 ++++++++-- test/registered/unit/test_model_overrides.py | 2 ++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/python/sglang/srt/server_args.py b/python/sglang/srt/server_args.py index 2f93fcd4b..be7028baf 100644 --- a/python/sglang/srt/server_args.py +++ b/python/sglang/srt/server_args.py @@ -1622,7 +1622,10 @@ class ServerArgs: ] = False disable_custom_all_reduce: A[ bool, - "Disable the custom all-reduce kernel and fall back to NCCL.", + Arg( + help="Disable the custom all-reduce kernel and fall back to NCCL.", + resolvable=True, + ), ] = False enable_mscclpp: A[ bool, @@ -1666,7 +1669,10 @@ class ServerArgs: resolvable=True, ), ] = None - enable_aiter_allreduce_fusion: A[bool, "Enable Aiter AllReduce Fusion."] = False + enable_aiter_allreduce_fusion: A[ + bool, + Arg(help="Enable Aiter AllReduce Fusion.", resolvable=True), + ] = False # ------------------------------------------------------------------------- # Torch compile and torchao diff --git a/test/registered/unit/test_model_overrides.py b/test/registered/unit/test_model_overrides.py index ccafe35fc..2701fe0b4 100644 --- a/test/registered/unit/test_model_overrides.py +++ b/test/registered/unit/test_model_overrides.py @@ -85,6 +85,8 @@ class TestModelOverridableWhitelist(CustomTestCase): "decode_attention_backend", "flashinfer_allreduce_fusion_backend", "fp8_gemm_runner_backend", + "disable_custom_all_reduce", + "enable_aiter_allreduce_fusion", } ), )