[CI] pr-test: Let stage wait jobs reach their max-wait budget (#44410)

This commit is contained in:
Xinyuan Tong
2026-10-15 13:34:49 -07:00
committed by GitHub
parent aa5c7e887c
commit 877be2974a
3 changed files with 37 additions and 14 deletions
+14 -6
View File
@@ -148,7 +148,12 @@ jobs:
{"prefix": "base-b-test-2-gpu-large", "expected_count": ${{ fromJson(needs.check-changes.outputs.partitions)['base-b-test-2-gpu-large'].size }}},
{"prefix": "base-b-test-4-gpu-b200", "expected_count": ${{ fromJson(needs.check-changes.outputs.partitions)['base-b-test-4-gpu-b200'].size }}}
]
max-wait-minutes: '480'
# 10 min under the 6h GitHub-hosted job cap: setup needs under 2 min, the rest is margin;
# timeout-minutes cannot raise the cap, and a wait killed by it ends `cancelled`.
max-wait-minutes: '350'
# pr-test-finish fails the run on any base-b failure, so this gate only saves GPU time;
# a slow base-b lets base-c start rather than costing the base-c run.
fail-on-timeout: 'false'
# =============================================== PR Gate ====================================================
call-gate:
@@ -344,7 +349,8 @@ jobs:
base-b-test:
name: base-b-test-${{ matrix.runner_config }}
needs: [check-changes, call-gate, wait-for-base-a, sgl-kernel-build-wheels, rust-ext-build]
if: ${{ !failure() && !cancelled() }}
# A cancelled need is neither failure() nor cancelled(), so check it explicitly.
if: ${{ !failure() && !cancelled() && needs.wait-for-base-a.result != 'cancelled' }}
strategy:
fail-fast: false
matrix:
@@ -388,8 +394,10 @@ jobs:
base-c-test:
name: base-c-test-${{ matrix.runner_config }}
needs: [check-changes, call-gate, wait-for-base-b, sgl-kernel-build-wheels, rust-ext-build]
if: ${{ !failure() && !cancelled() }}
# wait-for-base-a is listed only to read its result: when it is cancelled,
# wait-for-base-b ends `skipped`, which alone would let this stage through.
needs: [check-changes, call-gate, wait-for-base-a, wait-for-base-b, sgl-kernel-build-wheels, rust-ext-build]
if: ${{ !failure() && !cancelled() && needs.wait-for-base-a.result != 'cancelled' && needs.wait-for-base-b.result != 'cancelled' }}
strategy:
fail-fast: false
matrix:
@@ -431,8 +439,8 @@ jobs:
# the aarch64 build, and neither table should wait on the other's.
base-c-test-aarch64:
name: base-c-test-${{ matrix.runner_config }}
needs: [check-changes, call-gate, wait-for-base-b, sgl-kernel-build-wheels, rust-ext-build-aarch64]
if: ${{ !failure() && !cancelled() }}
needs: [check-changes, call-gate, wait-for-base-a, wait-for-base-b, sgl-kernel-build-wheels, rust-ext-build-aarch64]
if: ${{ !failure() && !cancelled() && needs.wait-for-base-a.result != 'cancelled' && needs.wait-for-base-b.result != 'cancelled' }}
strategy:
fail-fast: false
matrix: