docs: flesh out MAINTAINER.md oncall lists and link GitHub profiles (#21575)
This commit is contained in:
@@ -12,7 +12,7 @@
|
||||
|
||||
<!-- If this pull request affects model outputs (e.g., changes to the kernel or model forward code), provide accuracy test results. -->
|
||||
|
||||
## Benchmarking and Profiling
|
||||
## Speed Tests and Profiling
|
||||
|
||||
<!-- If this pull request impacts inference speed, provide benchmarking and profiling results. -->
|
||||
|
||||
@@ -24,10 +24,10 @@
|
||||
- [ ] Provide accuracy and speed benchmark results according to [Test the accuracy](https://docs.sglang.io/developer_guide/contribution_guide.html#test-the-accuracy) and [Benchmark the speed](https://docs.sglang.io/developer_guide/contribution_guide.html#benchmark-the-speed).
|
||||
- [ ] Follow the SGLang code style [guidance](https://docs.sglang.io/developer_guide/contribution_guide.html#code-style-guidance).
|
||||
|
||||
## Review Process
|
||||
## Review and Merge Process
|
||||
|
||||
1. Ping Merge Oncalls to start the PR flow. See the [PR Merge Process](https://github.com/sgl-project/sglang/blob/main/.github/MAINTAINER.md#pull-request-merge-process).
|
||||
1. Ping Merge Oncalls to start the process. See the [PR Merge Process](https://github.com/sgl-project/sglang/blob/main/.github/MAINTAINER.md#pull-request-merge-process).
|
||||
2. Get approvals from [CODEOWNERS](https://github.com/sgl-project/sglang/blob/main/.github/CODEOWNERS) and other reviewers.
|
||||
3. Trigger CI tests with [comments](https://docs.sglang.io/developer_guide/contribution_guide.html#how-to-trigger-ci-tests) or contact authorized users to do so.
|
||||
- `/tag-run-ci-label`, `/rerun-failed-ci`, `/tag-and-rerun-ci`
|
||||
4. After green CI and required approvals, ask Merge Oncalls to merge.
|
||||
- Common commands include `/tag-and-rerun-ci`, `/tag-run-ci-label`, `/rerun-failed-ci`
|
||||
4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.
|
||||
|
||||
Reference in New Issue
Block a user