From 80965db8d3fa89d97ef2d95d2cd1fd486caad963 Mon Sep 17 00:00:00 2001 From: YC Yen-Ching Tseng Date: Mon, 13 Jul 2026 09:20:17 +0800 Subject: [PATCH] [AMD] Pin cmake==4.3.4 in ROCm Dockerfile to fix MoRI gtest_discover build break (#30942) --- docker/rocm.Dockerfile | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/docker/rocm.Dockerfile b/docker/rocm.Dockerfile index 48a4c9021..3c2752cfd 100644 --- a/docker/rocm.Dockerfile +++ b/docker/rocm.Dockerfile @@ -357,8 +357,11 @@ RUN /bin/bash -lc 'set -euo pipefail; \ cp -v /tmp/build-gtest/lib/*.a /usr/lib/x86_64-linux-gnu/ && \ rm -rf /tmp/build-gtest; \ \ - # Keep setuptools < 80 (compat with base image) - "$VENV_PIP" install --upgrade "setuptools>=77.0.3,<80" wheel cmake ninja scikit-build-core && \ + # Keep setuptools < 80 (compat with base image). Pin cmake to the last known-good + # 4.3.4: cmake 4.4's gtest_discover_tests breaks the (pinned) MoRI build with a + # JSON parse error. This image is rebuilt daily, so pin the exact version for + # reproducible builds rather than letting cmake drift. + "$VENV_PIP" install --upgrade "setuptools>=77.0.3,<80" wheel "cmake==4.3.4" ninja scikit-build-core && \ "$VENV_PIP" cache purge || true; \ \ # Locate ROCm llvm-config; fallback to installing LLVM 18 if missing