minke.yu/sglang
1
0
Fork 0
Code Issues Pull Requests Actions 13 Packages Projects Releases Wiki Activity

Tiny fix wording about CI preemption. (#16773)

Browse Source
This commit is contained in:
Liangsheng Yin
2026-01-09 11:08:17 +08:00
committed by GitHub
parent 05dfef92a1
commit 77d3566555
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/pull_request_template.md
+2 -1
View File
@@ -28,5 +28,6 @@
1. Ping Merge Oncalls to start the PR flow. See the [PR Merge Process](https://github.com/sgl-project/sglang/blob/main/.github/MAINTAINER.md#pull-request-merge-process). 1. Ping Merge Oncalls to start the PR flow. See the [PR Merge Process](https://github.com/sgl-project/sglang/blob/main/.github/MAINTAINER.md#pull-request-merge-process).
2. Get approvals from [CODEOWNERS](https://github.com/sgl-project/sglang/blob/main/.github/CODEOWNERS) and other reviewers. 2. Get approvals from [CODEOWNERS](https://github.com/sgl-project/sglang/blob/main/.github/CODEOWNERS) and other reviewers.
3. Trigger CI tests with [comments](https://docs.sglang.io/developer_guide/contribution_guide.html#how-to-trigger-ci-tests) (`/tag-run-ci-label`, `/rerun-failed-ci`, `/tag-and-rerun-ci`) or contact authorized users to do so. 3. Trigger CI tests with [comments](https://docs.sglang.io/developer_guide/contribution_guide.html#how-to-trigger-ci-tests) or contact authorized users to do so.
- `/tag-run-ci-label`, `/rerun-failed-ci`, `/tag-and-rerun-ci`
4. After green CI and required approvals, ask Merge Oncalls to merge. 4. After green CI and required approvals, ask Merge Oncalls to merge.
.github/workflows/cancel-unfinished-pr-tests.yml
+2 -2
View File
@@ -1,4 +1,4 @@
name: Cancel Unfinished PR Tests name: Cancel Unfinished PR Runs
on: on:
workflow_dispatch: workflow_dispatch:
@@ -15,7 +15,7 @@ permissions:
pull-requests: read # needed for gh pr view (labels) pull-requests: read # needed for gh pr view (labels)
jobs: jobs:
cancel-pending-pr-test: cancel-unfinished-pr-runs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Install GitHub CLI - name: Install GitHub CLI
docs/developer_guide/contribution_guide.md
+2
View File
@@ -90,6 +90,8 @@ If you don’t have permission, please ask maintainers to trigger CI for you.
### CI rate limits ### CI rate limits
Due to CI scheduling and limited resources, higher-priority PRs may preempt running jobs. In such cases, you may need to rerun the tests.
We apply CI rate limits to prevent abuse and ensure fair usage of our CI resources. We apply CI rate limits to prevent abuse and ensure fair usage of our CI resources.
Each CI workflow has a default limit defined in its workflow configuration file. For example, in [pr-gate.yml](https://github.com/sgl-project/sglang/blob/main/.github/workflows/pr-gate.yml), the default cooldown period is 120 minutes, and each workflow can override it via the `cool-down-minutes` input parameter: Each CI workflow has a default limit defined in its workflow configuration file. For example, in [pr-gate.yml](https://github.com/sgl-project/sglang/blob/main/.github/workflows/pr-gate.yml), the default cooldown period is 120 minutes, and each workflow can override it via the `cool-down-minutes` input parameter: