From 75e77fca25c6e5ac81412f757de4ef759ac44e4a Mon Sep 17 00:00:00 2001 From: Chetan Kumar Verma <39086835+ckvermaAI@users.noreply.github.com> Date: Fri, 16 Oct 2026 07:52:09 +0530 Subject: [PATCH] [Fix] wan: fix opt-in Wan2.2 progressive mode and one-step transitions (#43768) Co-authored-by: Claude Sonnet 5 --- .../progressive_resolution/denoising.py | 3 ++- .../stages/progressive_resolution/wan.py | 5 +++- .../test_progressive.py | 23 +++++++++++++++++++ 3 files changed, 29 insertions(+), 2 deletions(-) diff --git a/python/sglang/multimodal_gen/runtime/pipelines_core/stages/progressive_resolution/denoising.py b/python/sglang/multimodal_gen/runtime/pipelines_core/stages/progressive_resolution/denoising.py index e9ef10f212..2ad985a85d 100644 --- a/python/sglang/multimodal_gen/runtime/pipelines_core/stages/progressive_resolution/denoising.py +++ b/python/sglang/multimodal_gen/runtime/pipelines_core/stages/progressive_resolution/denoising.py @@ -121,7 +121,8 @@ def find_transition_steps( for stage, threshold in stage_sigmas.items(): if stage == 1: continue - found = n_steps + # A threshold never reached still needs a full-res step to upsample into. + found = n_steps - 1 for step_index in range(n_steps): if sigmas_list[step_index] <= threshold: found = step_index diff --git a/python/sglang/multimodal_gen/runtime/pipelines_core/stages/progressive_resolution/wan.py b/python/sglang/multimodal_gen/runtime/pipelines_core/stages/progressive_resolution/wan.py index 00a21c8bb8..181684a0e2 100644 --- a/python/sglang/multimodal_gen/runtime/pipelines_core/stages/progressive_resolution/wan.py +++ b/python/sglang/multimodal_gen/runtime/pipelines_core/stages/progressive_resolution/wan.py @@ -47,11 +47,14 @@ class WanProgressiveDenoisingStage(ProgressiveDenoisingStage): - Initial noise must carry the temporal dimension T_lat. """ - def __init__(self, transformer, scheduler, pipeline=None, vae=None) -> None: + def __init__( + self, transformer, scheduler, pipeline=None, transformer_2=None, vae=None + ) -> None: super().__init__( transformer, scheduler, pipeline=pipeline, + transformer_2=transformer_2, vae=vae, spectrum_A=WAN_SPECTRUM_A, spectrum_beta=WAN_SPECTRUM_BETA, diff --git a/python/sglang/multimodal_gen/test/unit/progressive_resolution/test_progressive.py b/python/sglang/multimodal_gen/test/unit/progressive_resolution/test_progressive.py index 64e2b9186a..b6619648cb 100644 --- a/python/sglang/multimodal_gen/test/unit/progressive_resolution/test_progressive.py +++ b/python/sglang/multimodal_gen/test/unit/progressive_resolution/test_progressive.py @@ -5,6 +5,7 @@ import argparse import dataclasses import unittest from types import SimpleNamespace +from unittest import mock import torch @@ -217,6 +218,15 @@ class TestStageTransitionHelpers(unittest.TestCase): self.assertEqual(transitions, {2: 2, 3: 4}) + def test_find_transition_steps_keeps_unreached_threshold_before_last_step(self): + transitions = find_transition_steps( + torch.tensor([1.0, 0.0]), + {1: 1.0, 2: 0.5}, + n_steps=1, + ) + + self.assertEqual(transitions, {2: 0}) + def test_reset_scheduler_clears_solver_state(self): scheduler = SimpleNamespace( config=SimpleNamespace(solver_order=2), @@ -323,6 +333,19 @@ class TestProgressiveStageHelpers(unittest.TestCase): self.assertEqual(wan_stage._latent_scale_factor(wan_args), 8) self.assertEqual(ideogram_stage._latent_scale_factor(ideogram_args), 16) + def test_wan_dual_transformer_is_passed_to_base_stage(self): + transformer_2 = object() + with mock.patch.object( + ProgressiveDenoisingStage, "__init__", return_value=None + ) as base_init: + WanProgressiveDenoisingStage( + transformer=object(), + scheduler=object(), + transformer_2=transformer_2, + ) + + self.assertIs(base_init.call_args.kwargs["transformer_2"], transformer_2) + class TestLatentAdapters(unittest.TestCase): def test_flux_and_qwen_patchify_roundtrip(self):