minke.yu/sglang
1
0
Fork 0
Code Issues Pull Requests Actions 12 Packages Projects Releases Wiki Activity

Fix create_grammar_backend test calls with think_end_id (#22158)

Browse Source
This commit is contained in:
Shangming Cai
2026-04-06 00:54:35 +08:00
committed by GitHub
parent 5dd2c243eb
commit 75ab75d027
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/registered/unit/constrained/test_base_grammar_backend.py
+4 -7
View File
@@ -318,7 +318,6 @@ class TestCreateGrammarBackend(unittest.TestCase):
args = self._make_server_args("inner_r", reasoning_parser="deepseek") args = self._make_server_args("inner_r", reasoning_parser="deepseek")
tokenizer = MagicMock() tokenizer = MagicMock()
tokenizer.think_end_id = 42
result = create_grammar_backend(args, tokenizer, 32000) result = create_grammar_backend(args, tokenizer, 32000)
# Custom backends return early, no reasoner wrapping applied # Custom backends return early, no reasoner wrapping applied
@@ -386,22 +385,21 @@ class TestCreateGrammarBackend(unittest.TestCase):
mock_outlines_cls.return_value = mock_backend mock_outlines_cls.return_value = mock_backend
args = self._make_server_args("outlines", reasoning_parser="deepseek") args = self._make_server_args("outlines", reasoning_parser="deepseek")
tokenizer = MagicMock() tokenizer = MagicMock()
tokenizer.think_end_id = 42
result = create_grammar_backend(args, tokenizer, 32000) result = create_grammar_backend(args, tokenizer, 32000, think_end_id=42)
self.assertIsInstance(result, ReasonerGrammarBackend) self.assertIsInstance(result, ReasonerGrammarBackend)
self.assertEqual(result.think_end_id, 42) self.assertEqual(result.think_end_id, 42)
self.assertIs(result.grammar_backend, mock_backend) self.assertIs(result.grammar_backend, mock_backend)
@patch("sglang.srt.constrained.outlines_backend.OutlinesGrammarBackend") @patch("sglang.srt.constrained.outlines_backend.OutlinesGrammarBackend")
def test_no_reasoner_wrapping_without_think_end_id(self, mock_outlines_cls): def test_no_reasoner_wrapping_without_think_end_id(self, mock_outlines_cls):
"""Without think_end_id on tokenizer, no reasoner wrapping.""" """Without think_end_id passed in, no reasoner wrapping."""
mock_backend = MagicMock(spec=BaseGrammarBackend) mock_backend = MagicMock(spec=BaseGrammarBackend)
mock_outlines_cls.return_value = mock_backend mock_outlines_cls.return_value = mock_backend
args = self._make_server_args("outlines", reasoning_parser="deepseek") args = self._make_server_args("outlines", reasoning_parser="deepseek")
tokenizer = MagicMock(spec=[]) # No think_end_id attribute tokenizer = MagicMock(spec=[]) # No think_end_id attribute
result = create_grammar_backend(args, tokenizer, 32000) result = create_grammar_backend(args, tokenizer, 32000, think_end_id=None)
self.assertIs(result, mock_backend) self.assertIs(result, mock_backend)
@patch("sglang.srt.constrained.outlines_backend.OutlinesGrammarBackend") @patch("sglang.srt.constrained.outlines_backend.OutlinesGrammarBackend")
@@ -411,9 +409,8 @@ class TestCreateGrammarBackend(unittest.TestCase):
mock_outlines_cls.return_value = mock_backend mock_outlines_cls.return_value = mock_backend
args = self._make_server_args("outlines", reasoning_parser=None) args = self._make_server_args("outlines", reasoning_parser=None)
tokenizer = MagicMock() tokenizer = MagicMock()
tokenizer.think_end_id = 42
result = create_grammar_backend(args, tokenizer, 32000) result = create_grammar_backend(args, tokenizer, 32000, think_end_id=42)
self.assertIs(result, mock_backend) self.assertIs(result, mock_backend)
@patch("sglang.srt.constrained.xgrammar_backend.XGrammarGrammarBackend") @patch("sglang.srt.constrained.xgrammar_backend.XGrammarGrammarBackend")