[Misc] Use logger instead of print() in utils/common.py (#29004)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

test/registered/unit/utils/test_common.py

@@ -3,7 +3,11 @@ from array import array
 
 import torch
 
-from sglang.srt.utils.common import flatten_arrays_to_int64_tensor
+from sglang.srt.utils.common import (
+    flatten_arrays_to_int64_tensor,
+    get_device_sm_nvidia_smi,
+    get_nvidia_driver_version_str,
+)
 from sglang.test.ci.ci_register import register_cuda_ci
 from sglang.test.test_utils import CustomTestCase
 
@@ -46,5 +50,98 @@ class TestFlattenArraysToInt64Tensor(CustomTestCase):
         self._check(parts, [10, 20, 30, 100, 200, 1000])
 
 
+class TestNvidiaDriverVersionStr(CustomTestCase):
+    """`get_nvidia_driver_version_str` is typed as `str | None`: it returns
+    `None` when nvidia-smi is missing, fails, or emits an empty string. These
+    tests exercise both the success and the None-return paths by monkey-
+    patching `subprocess.run`, so they don't require a GPU. The function is
+    `@lru_cache`d, so the cache is cleared around each test to make the patch
+    observable.
+    """
+
+    def setUp(self):
+        get_nvidia_driver_version_str.cache_clear()
+
+    def tearDown(self):
+        get_nvidia_driver_version_str.cache_clear()
+
+    def test_returns_version_string(self):
+        import subprocess
+
+        class _R:
+            stdout = "595.58.03\n"
+
+        original = subprocess.run
+        subprocess.run = lambda *a, **k: _R()
+        try:
+            self.assertEqual(get_nvidia_driver_version_str(), "595.58.03")
+        finally:
+            subprocess.run = original
+
+    def test_returns_none_on_empty_output(self):
+        import subprocess
+
+        class _R:
+            stdout = "\n"
+
+        original = subprocess.run
+        subprocess.run = lambda *a, **k: _R()
+        try:
+            self.assertIsNone(get_nvidia_driver_version_str())
+        finally:
+            subprocess.run = original
+
+    def test_returns_none_on_called_process_error(self):
+        import subprocess
+
+        original = subprocess.run
+
+        def boom(*a, **k):
+            raise subprocess.CalledProcessError(1, "nvidia-smi")
+
+        subprocess.run = boom
+        try:
+            self.assertIsNone(get_nvidia_driver_version_str())
+        finally:
+            subprocess.run = original
+
+    def test_returns_none_on_file_not_found(self):
+        import subprocess
+
+        original = subprocess.run
+
+        def boom(*a, **k):
+            raise FileNotFoundError("nvidia-smi")
+
+        subprocess.run = boom
+        try:
+            self.assertIsNone(get_nvidia_driver_version_str())
+        finally:
+            subprocess.run = original
+
+
+class TestGetDeviceSmNvidiaSmi(CustomTestCase):
+    """`get_device_sm_nvidia_smi` parses nvidia-smi output into a (major,
+    minor) tuple and falls back to (0, 0) -- logging via `logger.error` --
+    when nvidia-smi fails. The success path needs a GPU; the fallback path is
+    covered here by forcing a failure and asserting the (0, 0) return. The
+    fallback path needs no GPU, so this test runs on CPU.
+    """
+
+    def test_fallback_on_failure_returns_zero_zero(self):
+        import subprocess
+
+        original = subprocess.run
+
+        def boom(*a, **k):
+            raise subprocess.CalledProcessError(1, "nvidia-smi")
+
+        subprocess.run = boom
+        try:
+            self.assertEqual(get_device_sm_nvidia_smi(), (0, 0))
+        finally:
+            subprocess.run = original
+
+
 if __name__ == "__main__":
     unittest.main()