From 72eb231d28f57d73c58814b3346c1d61b6b8de43 Mon Sep 17 00:00:00 2001 From: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com> Date: Sat, 16 May 2026 09:22:13 +0800 Subject: [PATCH] Annotate dead max_running_requests_under_SLO (#25441) --- python/sglang/srt/managers/scheduler.py | 1 + python/sglang/srt/observability/scheduler_metrics_mixin.py | 1 + 2 files changed, 2 insertions(+) diff --git a/python/sglang/srt/managers/scheduler.py b/python/sglang/srt/managers/scheduler.py index b2104ef73..078240792 100644 --- a/python/sglang/srt/managers/scheduler.py +++ b/python/sglang/srt/managers/scheduler.py @@ -784,6 +784,7 @@ class Scheduler( if self.enable_metrics: self.metrics_collector.emit_constants( max_total_num_tokens=self.max_total_num_tokens, + # TODO: max_running_requests_under_SLO has no setter — dead chain. max_running_requests_under_SLO=getattr( self, "max_running_requests_under_SLO", None ), diff --git a/python/sglang/srt/observability/scheduler_metrics_mixin.py b/python/sglang/srt/observability/scheduler_metrics_mixin.py index 2bff486ca..a252474b4 100644 --- a/python/sglang/srt/observability/scheduler_metrics_mixin.py +++ b/python/sglang/srt/observability/scheduler_metrics_mixin.py @@ -954,6 +954,7 @@ class SchedulerMetricsMixin: if self.disaggregation_mode == DisaggregationMode.PREFILL: self.stats.utilization = -1 else: + # TODO: max_running_requests_under_SLO has no setter — sglang:utilization stuck at 0 (regressed #22713). max_under_slo = getattr(self, "max_running_requests_under_SLO", None) if max_under_slo is not None and max_under_slo > 0: self.stats.utilization = max(