From 68673fe6c58b907a5da89b1f92a6972f74dc0086 Mon Sep 17 00:00:00 2001 From: YC Yen-Ching Tseng Date: Wed, 29 Jul 2026 12:19:17 +0800 Subject: [PATCH] [AMD] add Gemma3RMSNorm.forward_hip to unbreak ROCm (#32613) --- python/sglang/srt/layers/layernorm.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/python/sglang/srt/layers/layernorm.py b/python/sglang/srt/layers/layernorm.py index 2cd3b4eae..f7643efe2 100644 --- a/python/sglang/srt/layers/layernorm.py +++ b/python/sglang/srt/layers/layernorm.py @@ -1087,6 +1087,11 @@ class Gemma3RMSNorm(MultiPlatformOp): return gemma_rmsnorm(x, self.weight.data, self.eps) return self.forward_native(x) + def forward_hip(self, x, residual: Optional[torch.Tensor] = None): + # sgl_kernel's gemma_rmsnorm/gemma_fused_add_rmsnorm are not available on + # ROCm; delegate to the pure-PyTorch implementation. + return self.forward_native(x, residual) + def forward_npu(self, x, residual: Optional[torch.Tensor] = None): if residual is not None: return self.forward_native(x, residual)