[diffusion] fix: fix the load duration missing from subclassed server tests (#40657)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Michael <michaelzhang-ai@users.noreply.github.com>
Co-authored-by: quitenode <quitenode@users.noreply.github.com>
Co-authored-by: jacky.cheng <yichiche@amd.com>
This commit is contained in:
Michael
2026-10-15 13:38:23 +08:00
committed by GitHub
co-authored by Cursor Agent Michael quitenode jacky.cheng
parent f9bdb74a5a
commit 676c038aa5
5 changed files with 14 additions and 8 deletions
@@ -390,12 +390,17 @@ class DiffusionServerBase:
def _validate_and_record(
self,
ctx: ServerContext,
case: DiffusionTestCase,
perf_record: RequestPerfRecord,
request_index: int = 1,
load_time_ms: float | None = None,
) -> None:
"""Validate metrics and record results."""
"""Validate metrics and record results.
The load duration is read off ``ctx`` rather than passed separately:
recording a result requires it, and a caller that has the server always
has the measurement.
"""
if perf_record is None:
raise PerformanceValidationError(
f"[performance] {case.id}: request performance record is missing"
@@ -426,7 +431,7 @@ class DiffusionServerBase:
)
summary = validator.collect_metrics(perf_record)
summary.load_time_ms = load_time_ms
summary.load_time_ms = ctx.load_time_ms
self._record_performance_result(case, summary, request_index)
self._print_performance_log(case, summary, scenario)
@@ -1727,7 +1732,7 @@ Pinned revision used by this check: {SGL_TEST_FILES_CI_DATA_REVISION}
run_case_check(
"performance",
lambda: self._validate_and_record(
case, perf_record, request_index, diffusion_server.load_time_ms
diffusion_server, case, perf_record, request_index
),
)
@@ -3,6 +3,7 @@ import subprocess
import sys
import textwrap
import time
from types import SimpleNamespace
import pytest
@@ -80,7 +81,7 @@ def test_e2e_only_does_not_require_stage_metrics(monkeypatch, generate_baseline)
steps=[],
total_duration_ms=2000 if generate_baseline else 1000,
)
server._validate_and_record(case, record, load_time_ms=100)
server._validate_and_record(SimpleNamespace(load_time_ms=100), case, record)
assert len(server._perf_results) == 1
assert bool(common._PENDING_BASELINE_DUMPS) == generate_baseline