[Fix] spec: Remove --speculative-skip-dp-mlp-sync (#45043)
This commit is contained in:
@@ -288,7 +288,6 @@ POSITIONAL_FIELD_ORDER = (
|
||||
"speculative_enable_w4a4_mxfp4_megamoe",
|
||||
"speculative_draft_model_quantization",
|
||||
"_speculative_draft_quantization_explicitly_set",
|
||||
"speculative_skip_dp_mlp_sync",
|
||||
"enable_multi_layer_eagle",
|
||||
"speculative_adaptive",
|
||||
"speculative_adaptive_config",
|
||||
|
||||
@@ -226,10 +226,6 @@ class Spec(msgspec.Struct):
|
||||
Optional[bool],
|
||||
Arg(no_cli=True),
|
||||
] = None
|
||||
speculative_skip_dp_mlp_sync: A[
|
||||
bool,
|
||||
"Skip the extra MLP sync that the scheduler performs before merging a new batch when speculative decoding + DP attention are both enabled.",
|
||||
] = False
|
||||
enable_multi_layer_eagle: A[
|
||||
bool,
|
||||
Arg(
|
||||
|
||||
@@ -248,12 +248,6 @@ def handle_speculative_decoding(server_args: ServerArgs) -> None:
|
||||
algo.validate_server_args,
|
||||
)
|
||||
|
||||
if cfg.speculative_skip_dp_mlp_sync:
|
||||
assert cfg.speculative_algorithm == "EAGLE", (
|
||||
"--speculative-skip-dp-mlp-sync is only supported with "
|
||||
f"speculative_algorithm == EAGLE, got {cfg.speculative_algorithm}."
|
||||
)
|
||||
|
||||
if envs.SGLANG_ENABLE_DP_SPEC_PREFILL_COORDINATION.get():
|
||||
if (
|
||||
cfg.speculative_algorithm not in ("EAGLE", "EAGLE3", "DSPARK")
|
||||
|
||||
@@ -3914,7 +3914,6 @@ class Scheduler(
|
||||
if (
|
||||
need_mlp_sync
|
||||
and not self.spec_algorithm.is_none()
|
||||
and not get_spec().speculative_skip_dp_mlp_sync
|
||||
and not envs.SGLANG_ENABLE_DP_SPEC_PREFILL_COORDINATION.get()
|
||||
):
|
||||
# NOTE: This branch makes sure prefill and decode batches will not be mixed when spec and dp-attn is enabled.
|
||||
|
||||
@@ -171,7 +171,6 @@ class DSparkVerifyPlanner:
|
||||
and get_parallel().attn_cp_size == 1
|
||||
and require_mlp_tp_gather()
|
||||
and not get_schedule().disable_overlap_schedule
|
||||
and not get_spec().speculative_skip_dp_mlp_sync
|
||||
and get_disagg().disaggregation_mode == "null"
|
||||
and get_parallel().pp_size == 1
|
||||
and not envs.SGLANG_SCHEDULER_SKIP_ALL_GATHER.get()
|
||||
|
||||
Reference in New Issue
Block a user