Fix extra calls to get_numa_node_if_available to clean up logs (#21781)

This commit is contained in:
Trevor Morris
2026-04-06 16:18:40 -07:00
committed by GitHub
parent 56266de624
commit 5cc246e095
2 changed files with 15 additions and 11 deletions
+4 -3
View File
@@ -3578,9 +3578,10 @@ def run_scheduler_process(
set_gpu_proc_affinity( set_gpu_proc_affinity(
server_args.pp_size, server_args.tp_size, server_args.nnodes, gpu_id server_args.pp_size, server_args.tp_size, server_args.nnodes, gpu_id
) )
numa_node = get_numa_node_if_available(server_args, gpu_id) if not envs.SGLANG_NUMA_BIND_V2.get():
if numa_node is not None and not envs.SGLANG_NUMA_BIND_V2.get(): numa_node = get_numa_node_if_available(server_args, gpu_id)
numa_bind_to_node(numa_node) if numa_node is not None:
numa_bind_to_node(numa_node)
# Set up tracing # Set up tracing
if server_args.enable_trace: if server_args.enable_trace:
+11 -8
View File
@@ -24,14 +24,17 @@ logger = logging.getLogger(__name__)
@contextmanager @contextmanager
def configure_subprocess(server_args: ServerArgs, gpu_id: int): def configure_subprocess(server_args: ServerArgs, gpu_id: int):
numa_node = get_numa_node_if_available(server_args, gpu_id) if envs.SGLANG_NUMA_BIND_V2.get():
if numa_node is not None and envs.SGLANG_NUMA_BIND_V2.get(): numa_node = get_numa_node_if_available(server_args, gpu_id)
numactl_args = f"--cpunodebind={numa_node} --membind={numa_node}" if numa_node is not None:
executable, debug_str = _create_numactl_executable(numactl_args=numactl_args) numactl_args = f"--cpunodebind={numa_node} --membind={numa_node}"
with _mp_set_executable(executable=executable, debug_str=debug_str): executable, debug_str = _create_numactl_executable(
yield numactl_args=numactl_args
else: )
yield with _mp_set_executable(executable=executable, debug_str=debug_str):
yield
return
yield
def _create_numactl_executable(numactl_args: str): def _create_numactl_executable(numactl_args: str):