[mm] Accept per-item embedding lists from DataEmbeddingFunc (#31826)
This commit is contained in:
@@ -0,0 +1,149 @@
|
||||
"""Unit tests for per-item DataEmbeddingFunc results in the chunked mm path.
|
||||
|
||||
A DataEmbeddingFunc may return either one combined [tokens, hidden] tensor or
|
||||
one tensor per item (see mm_utils.DataEmbeddingFunc). These tests assert the
|
||||
two forms produce bitwise-identical chunked-prefill embeddings, and that the
|
||||
per-item form yields cache entries that own their storage (a torch.split view
|
||||
of the combined tensor pins the whole concatenated buffer).
|
||||
|
||||
CPU-only: exercises mm_utils internals directly, no engine or GPU.
|
||||
"""
|
||||
|
||||
import pytest
|
||||
import torch
|
||||
|
||||
from sglang.srt.managers import mm_utils
|
||||
from sglang.srt.managers.schedule_batch import Modality, MultimodalDataItem
|
||||
from sglang.test.ci.ci_register import register_cpu_ci
|
||||
|
||||
register_cpu_ci(est_time=10, suite="base-b-test-cpu")
|
||||
|
||||
HIDDEN = 16
|
||||
|
||||
# Three items with text gaps between their placeholder runs; offsets are
|
||||
# (start, end) inclusive, mirroring processor output.
|
||||
ITEM_OFFSETS = [(2, 5), (9, 14), (20, 24)]
|
||||
TOTAL_LEN = 30
|
||||
|
||||
# Chunk windows (prefix_len, extend_len) covering the sequence, sized so item
|
||||
# boundaries fall both inside and across chunks.
|
||||
CHUNKS = [(0, 8), (8, 8), (16, 8), (24, 6)]
|
||||
|
||||
_CPU = torch.device("cpu")
|
||||
|
||||
|
||||
def _num_tokens(item: MultimodalDataItem) -> int:
|
||||
start, end = item.offsets[0]
|
||||
return end - start + 1
|
||||
|
||||
|
||||
def _item_embedding(item: MultimodalDataItem) -> torch.Tensor:
|
||||
gen = torch.Generator().manual_seed(item.hash)
|
||||
return torch.randn(_num_tokens(item), HIDDEN, generator=gen)
|
||||
|
||||
|
||||
def _encoder_tensor(items):
|
||||
return torch.cat([_item_embedding(item) for item in items], dim=0)
|
||||
|
||||
|
||||
def _encoder_list(items):
|
||||
return [_item_embedding(item) for item in items]
|
||||
|
||||
|
||||
def _make_items():
|
||||
return [
|
||||
MultimodalDataItem(
|
||||
modality=Modality.IMAGE,
|
||||
hash=1000 + i,
|
||||
feature=torch.zeros(1),
|
||||
offsets=[offset],
|
||||
)
|
||||
for i, offset in enumerate(ITEM_OFFSETS)
|
||||
]
|
||||
|
||||
|
||||
def _run_by_item_chunks(encoder):
|
||||
mm_utils.init_mm_embedding_cache(1 << 30)
|
||||
items = _make_items()
|
||||
return [
|
||||
mm_utils._get_chunked_embedding_by_item(
|
||||
encoder, items, ITEM_OFFSETS, prefix_len, extend_len, _CPU
|
||||
)
|
||||
for prefix_len, extend_len in CHUNKS
|
||||
]
|
||||
|
||||
|
||||
def _run_full_chunks(encoder):
|
||||
mm_utils.init_mm_embedding_cache(1 << 30)
|
||||
items = _make_items()
|
||||
input_ids = torch.zeros(TOTAL_LEN, dtype=torch.long)
|
||||
outs = []
|
||||
for prefix_len, extend_len in CHUNKS:
|
||||
chunk, _ = mm_utils._get_chunked_embedding_full(
|
||||
encoder, items, ITEM_OFFSETS, prefix_len, extend_len, input_ids, _CPU
|
||||
)
|
||||
outs.append(chunk)
|
||||
return outs
|
||||
|
||||
|
||||
def _assert_chunks_equal(chunks_a, chunks_b):
|
||||
assert len(chunks_a) == len(chunks_b)
|
||||
for a, b in zip(chunks_a, chunks_b):
|
||||
if a is None or b is None:
|
||||
assert a is None and b is None
|
||||
continue
|
||||
assert a.shape == b.shape
|
||||
torch.testing.assert_close(a, b, rtol=0, atol=0)
|
||||
|
||||
|
||||
def test_by_item_list_matches_tensor():
|
||||
_assert_chunks_equal(
|
||||
_run_by_item_chunks(_encoder_tensor), _run_by_item_chunks(_encoder_list)
|
||||
)
|
||||
|
||||
|
||||
def test_full_list_matches_tensor():
|
||||
_assert_chunks_equal(
|
||||
_run_full_chunks(_encoder_tensor), _run_full_chunks(_encoder_list)
|
||||
)
|
||||
|
||||
|
||||
def test_full_matches_by_item():
|
||||
# The two chunked strategies agree with each other for single-offset items.
|
||||
_assert_chunks_equal(
|
||||
_run_full_chunks(_encoder_tensor), _run_by_item_chunks(_encoder_list)
|
||||
)
|
||||
|
||||
|
||||
def test_list_cache_entries_own_storage():
|
||||
mm_utils.init_mm_embedding_cache(1 << 30)
|
||||
items = _make_items()
|
||||
mm_utils._get_chunked_embedding_by_item(
|
||||
_encoder_list, items, ITEM_OFFSETS, 0, TOTAL_LEN, _CPU
|
||||
)
|
||||
for item in items:
|
||||
emb = mm_utils.embedding_cache.get_single(item.hash).embedding
|
||||
own_bytes = emb.numel() * emb.element_size()
|
||||
assert emb.untyped_storage().nbytes() == own_bytes
|
||||
|
||||
|
||||
def test_tensor_cache_entries_share_storage():
|
||||
# Documents the motivation for the per-item form: split views of the
|
||||
# combined tensor keep the whole concatenated buffer alive.
|
||||
mm_utils.init_mm_embedding_cache(1 << 30)
|
||||
items = _make_items()
|
||||
mm_utils._get_chunked_embedding_by_item(
|
||||
_encoder_tensor, items, ITEM_OFFSETS, 0, TOTAL_LEN, _CPU
|
||||
)
|
||||
total_tokens = sum(_num_tokens(item) for item in items)
|
||||
for item in items:
|
||||
emb = mm_utils.embedding_cache.get_single(item.hash).embedding
|
||||
assert (
|
||||
emb.untyped_storage().nbytes() == total_tokens * HIDDEN * emb.element_size()
|
||||
)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
import sys
|
||||
|
||||
sys.exit(pytest.main([__file__, "-v"]))
|
||||
Reference in New Issue
Block a user