From 3fb721917daf371a267d3bb08676727ed3ca6b29 Mon Sep 17 00:00:00 2001 From: stanleys12 Date: Wed, 30 Sep 2026 19:23:12 -0700 Subject: [PATCH] [Fix] Require admin auth for /load_lora_adapter_from_tensors and /set_trace_level (#41322) Co-authored-by: Claude Opus 5 --- python/sglang/srt/entrypoints/http_server.py | 2 + .../test_http_server_auth_levels.py | 46 +++++++++++++++++++ 2 files changed, 48 insertions(+) create mode 100644 test/registered/unit/entrypoints/test_http_server_auth_levels.py diff --git a/python/sglang/srt/entrypoints/http_server.py b/python/sglang/srt/entrypoints/http_server.py index 6dc6e215de..587b3e782f 100644 --- a/python/sglang/srt/entrypoints/http_server.py +++ b/python/sglang/srt/entrypoints/http_server.py @@ -1184,6 +1184,7 @@ async def stop_profile_async(): @app.api_route("/set_trace_level", methods=["GET", "POST"]) +@auth_level(AuthLevel.ADMIN_OPTIONAL) def set_trace_level(level: int = Query(..., ge=0)): set_global_trace_level(level) @@ -1603,6 +1604,7 @@ async def load_lora_adapter( @app.api_route("/load_lora_adapter_from_tensors", methods=["POST"]) +@auth_level(AuthLevel.ADMIN_OPTIONAL) async def load_lora_adapter_from_tensors( obj: Annotated[LoadLoRAAdapterFromTensorsReqInput, Body()], request: Request ): diff --git a/test/registered/unit/entrypoints/test_http_server_auth_levels.py b/test/registered/unit/entrypoints/test_http_server_auth_levels.py new file mode 100644 index 0000000000..6efff3fae8 --- /dev/null +++ b/test/registered/unit/entrypoints/test_http_server_auth_levels.py @@ -0,0 +1,46 @@ +import unittest + +from sglang.srt.entrypoints.http_server import app +from sglang.srt.utils.auth import ( + _get_auth_level_from_app_and_scope, + decide_request_auth, +) +from sglang.test.ci.ci_register import register_cpu_ci +from sglang.test.test_utils import CustomTestCase + +register_cpu_ci(est_time=12, suite="base-a-test-cpu") + +ADMIN_PATHS = [ + "/load_lora_adapter", + "/load_lora_adapter_from_tensors", + "/unload_lora_adapter", + "/start_profile", + "/stop_profile", + "/set_trace_level", + "/freeze_gc", +] + + +class TestAdminEndpointAuthLevels(CustomTestCase): + def _decide(self, path: str, authorization_header: str | None): + scope = {"type": "http", "method": "POST", "path": path, "root_path": ""} + return decide_request_auth( + method="POST", + path=path, + authorization_header=authorization_header, + api_key=None, + admin_api_key="admin-secret", + auth_level=_get_auth_level_from_app_and_scope(app, scope), + ) + + def test_state_mutating_endpoints_require_admin_api_key(self): + """A route missing @auth_level resolves to NORMAL, which a server started + with only --admin-api-key leaves open to unauthenticated requests.""" + for path in ADMIN_PATHS: + with self.subTest(path=path): + self.assertFalse(self._decide(path, None).allowed) + self.assertTrue(self._decide(path, "Bearer admin-secret").allowed) + + +if __name__ == "__main__": + unittest.main()