From 2bc435d32e6e6a8d3363892fc1a4db10ed1712ec Mon Sep 17 00:00:00 2001 From: Shuwen Wang <47200617+alphabetc1@users.noreply.github.com> Date: Wed, 23 Sep 2026 10:52:03 +0800 Subject: [PATCH] [HiCache] fix: bound the controller reset join so a stalled storage thread cannot hang the scheduler (#40312) --- python/sglang/srt/managers/cache_controller.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/python/sglang/srt/managers/cache_controller.py b/python/sglang/srt/managers/cache_controller.py index ba49418fe9..474623a6f7 100644 --- a/python/sglang/srt/managers/cache_controller.py +++ b/python/sglang/srt/managers/cache_controller.py @@ -750,17 +750,15 @@ class HiCacheController: ) def reset(self): - self.storage_stop_event.set() + # Reuse detach's queue wakeups and bounded joins, and fail if any + # storage thread remains alive before clearing shared state. + self._stop_storage_threads() self.write_queue.clear() self.load_queue.clear() self.ack_write_queue.clear() self.ack_load_queue.clear() if self.enable_storage: - self.prefetch_thread.join() - self.prefetch_io_aux_thread.join() - self.prefetch_sync_thread.join() - self.backup_thread.join() self.prefetch_queue.queue.clear() self.backup_queue.queue.clear() self.prefetch_buffer.queue.clear()