From 1e86143bf06d40082de878f05b8782b043f61ad2 Mon Sep 17 00:00:00 2001 From: "Po-Han Huang (NVIDIA)" <53919306+nvpohanh@users.noreply.github.com> Date: Wed, 7 Oct 2026 21:02:40 +0800 Subject: [PATCH] [Bugfix] Return None for empty reasoning_content outside K2 Horizon (#42962) Co-authored-by: Claude Opus 5.5 --- python/sglang/srt/entrypoints/openai/serving_chat.py | 7 ++++++- .../unit/entrypoints/openai/test_serving_chat.py | 12 ++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/python/sglang/srt/entrypoints/openai/serving_chat.py b/python/sglang/srt/entrypoints/openai/serving_chat.py index 49f0dd5b6a..04f30d2f8f 100644 --- a/python/sglang/srt/entrypoints/openai/serving_chat.py +++ b/python/sglang/srt/entrypoints/openai/serving_chat.py @@ -2453,7 +2453,12 @@ class OpenAIServingChat(OpenAIServingBase): role="assistant", content=text if text else "", tool_calls=tool_calls, - reasoning_content=reasoning_text, + # Only K2 templates replay empty reasoning; other parsers report None. + reasoning_content=( + reasoning_text + if reasoning_text or self.reasoning_parser == "k2_horizon" + else None + ), ), logprobs=choice_logprobs, finish_reason=finish_reason["type"] if finish_reason else None, diff --git a/test/registered/unit/entrypoints/openai/test_serving_chat.py b/test/registered/unit/entrypoints/openai/test_serving_chat.py index c0bb2ec102..b594e7cbc8 100644 --- a/test/registered/unit/entrypoints/openai/test_serving_chat.py +++ b/test/registered/unit/entrypoints/openai/test_serving_chat.py @@ -4399,6 +4399,18 @@ class ServingChatTestCase(CustomTestCase): for choice in chunk.get("choices", []): self.assertIsNone(choice["delta"].get("reasoning_content")) + def test_empty_reasoning_is_null_for_non_k2_parser(self): + """A non-K2 parser that finds no reasoning reports reasoning_content as None, not ''.""" + self.chat.reasoning_parser = "qwen3" + self.template_manager.force_reasoning = False + request = self.basic_req.model_copy(update={"separate_reasoning": True}) + ret = _spec_result(0) + ret["text"] = "Hello" + response = self.chat._build_chat_response(request, [ret], created=123) + message = response.choices[0].message + self.assertEqual(message.content, "Hello") + self.assertIsNone(message.reasoning_content) + def test_missing_reasoning_history_still_rejected(self): self._use_preserved_reasoning_template() for reasoning in ({}, {"reasoning_content": None}):