From 16eb87c06fca4b14f91ddc1503e2353f70094ff2 Mon Sep 17 00:00:00 2001 From: Muqi Li Date: Tue, 20 Oct 2026 17:11:06 +0800 Subject: [PATCH] [Fix] openai: distinguish s3 served-model-name from LoRA adapter syntax (#44450) Signed-off-by: Muqi Li Signed-off-by: Xinyuan Tong Co-authored-by: Xinyuan Tong Co-authored-by: Xinyuan Tong <115166877+JustinTong0323@users.noreply.github.com> --- .../srt/entrypoints/openai/serving_base.py | 19 +++++++++++++------ test/registered/lora/test_lora_openai_api.py | 1 + 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/python/sglang/srt/entrypoints/openai/serving_base.py b/python/sglang/srt/entrypoints/openai/serving_base.py index 04dfe2cab6..d00b475ad5 100644 --- a/python/sglang/srt/entrypoints/openai/serving_base.py +++ b/python/sglang/srt/entrypoints/openai/serving_base.py @@ -40,17 +40,24 @@ class OpenAIServingBase(ABC): def _parse_model_parameter(self, model: str) -> Tuple[str, Optional[str]]: """Parse 'base-model:adapter-name' syntax to extract LoRA adapter. - Returns (base_model, adapter_name) or (model, None) if no colon present. + Returns (base_model, adapter_name), preserving an exact served model + name even when it contains colons (e.g. an object-storage URI). """ if ":" not in model: return model, None - # Split on first colon only to handle model paths with multiple colons - parts = model.split(":", 1) - base_model = parts[0].strip() - adapter_name = parts[1].strip() or None + served_model_name = self.tokenizer_manager.served_model_name + if model == served_model_name: + return model, None - return base_model, adapter_name + # Match the full served name before splitting URI schemes like s3://. + if model.startswith(f"{served_model_name}:"): + base_model = served_model_name + adapter_name = model[len(served_model_name) + 1 :] + else: + base_model, adapter_name = model.split(":", 1) + + return base_model.strip(), adapter_name.strip() or None def _resolve_lora_path( self, diff --git a/test/registered/lora/test_lora_openai_api.py b/test/registered/lora/test_lora_openai_api.py index c9813e0d9c..7cc00832a1 100644 --- a/test/registered/lora/test_lora_openai_api.py +++ b/test/registered/lora/test_lora_openai_api.py @@ -33,6 +33,7 @@ class MockTokenizerManager: def __init__(self, enable_lora=False): self.server_args = MagicMock(spec=ServerArgs) self.server_args.enable_lora = enable_lora + self.served_model_name = "test-model" class ConcreteServingBase(OpenAIServingBase):