Fix socket utilities and reserve_port for IPv6 dual-stack support (#20491)
Co-authored-by: hnyls2002 <lsyincs@gmail.com>
This commit is contained in:
@@ -0,0 +1,156 @@
|
||||
import os
|
||||
import socket
|
||||
import unittest
|
||||
from unittest.mock import patch
|
||||
|
||||
from sglang.srt.utils.common import (
|
||||
_get_addrinfos_for_bind,
|
||||
bind_port,
|
||||
get_free_port,
|
||||
get_open_port,
|
||||
is_port_available,
|
||||
try_bind_socket,
|
||||
)
|
||||
from sglang.test.ci.ci_register import register_cpu_ci
|
||||
from sglang.test.test_utils import CustomTestCase
|
||||
|
||||
register_cpu_ci(est_time=1, suite="stage-a-cpu-only")
|
||||
|
||||
|
||||
class TestTryBindSocket(CustomTestCase):
|
||||
def test_bind_ephemeral_port(self):
|
||||
"""try_bind_socket() with port=0 should bind to an OS-assigned port."""
|
||||
sock = try_bind_socket()
|
||||
try:
|
||||
port = sock.getsockname()[1]
|
||||
self.assertGreater(port, 0)
|
||||
self.assertLessEqual(port, 65535)
|
||||
finally:
|
||||
sock.close()
|
||||
|
||||
def test_bind_specific_port(self):
|
||||
"""try_bind_socket(port=N) should bind to that exact port."""
|
||||
port = get_free_port()
|
||||
sock = try_bind_socket(port=port)
|
||||
try:
|
||||
self.assertEqual(sock.getsockname()[1], port)
|
||||
finally:
|
||||
sock.close()
|
||||
|
||||
def test_bind_with_listen(self):
|
||||
"""try_bind_socket(listen=True) should return a listening socket."""
|
||||
sock = try_bind_socket(listen=True)
|
||||
try:
|
||||
# A listening socket has a valid bound address
|
||||
port = sock.getsockname()[1]
|
||||
self.assertGreater(port, 0)
|
||||
finally:
|
||||
sock.close()
|
||||
|
||||
def test_bind_with_host(self):
|
||||
"""try_bind_socket(host='127.0.0.1') should bind to localhost."""
|
||||
sock = try_bind_socket(host="127.0.0.1")
|
||||
try:
|
||||
addr = sock.getsockname()
|
||||
self.assertEqual(addr[0], "127.0.0.1")
|
||||
finally:
|
||||
sock.close()
|
||||
|
||||
def test_bind_occupied_port_raises(self):
|
||||
"""try_bind_socket should raise OSError if port is occupied."""
|
||||
sock1 = try_bind_socket()
|
||||
try:
|
||||
port = sock1.getsockname()[1]
|
||||
with self.assertRaises(OSError):
|
||||
try_bind_socket(port=port, reuse_addr=False)
|
||||
finally:
|
||||
sock1.close()
|
||||
|
||||
def test_returns_correct_family(self):
|
||||
"""Returned socket should be AF_INET or AF_INET6."""
|
||||
sock = try_bind_socket()
|
||||
try:
|
||||
self.assertIn(sock.family, (socket.AF_INET, socket.AF_INET6))
|
||||
finally:
|
||||
sock.close()
|
||||
|
||||
def test_gaierror_fallback(self):
|
||||
"""_get_addrinfos_for_bind should fall back to AF_INET on gaierror."""
|
||||
with patch(
|
||||
"sglang.srt.utils.common.socket.getaddrinfo",
|
||||
side_effect=socket.gaierror("mocked"),
|
||||
):
|
||||
infos = _get_addrinfos_for_bind()
|
||||
self.assertEqual(len(infos), 1)
|
||||
family, socktype, _, _, sockaddr = infos[0]
|
||||
self.assertEqual(family, socket.AF_INET)
|
||||
self.assertEqual(sockaddr[0], "0.0.0.0")
|
||||
|
||||
def test_gaierror_fallback_preserves_host(self):
|
||||
"""Fallback should use the provided host, not default to 0.0.0.0."""
|
||||
with patch(
|
||||
"sglang.srt.utils.common.socket.getaddrinfo",
|
||||
side_effect=socket.gaierror("mocked"),
|
||||
):
|
||||
infos = _get_addrinfos_for_bind(host="10.0.0.1", port=8080)
|
||||
self.assertEqual(infos[0][4], ("10.0.0.1", 8080))
|
||||
|
||||
|
||||
class TestSocketUtilities(CustomTestCase):
|
||||
def test_is_port_available(self):
|
||||
"""is_port_available should return True for a free port."""
|
||||
port = get_free_port()
|
||||
self.assertTrue(is_port_available(port))
|
||||
|
||||
def test_is_port_available_occupied(self):
|
||||
"""is_port_available should return False for an occupied port."""
|
||||
sock = bind_port(get_free_port())
|
||||
try:
|
||||
port = sock.getsockname()[1]
|
||||
self.assertFalse(is_port_available(port))
|
||||
finally:
|
||||
sock.close()
|
||||
|
||||
def test_get_free_port(self):
|
||||
"""get_free_port should return a valid port number."""
|
||||
port = get_free_port()
|
||||
self.assertGreater(port, 0)
|
||||
self.assertLessEqual(port, 65535)
|
||||
|
||||
def test_bind_port(self):
|
||||
"""bind_port should return a listening socket."""
|
||||
port = get_free_port()
|
||||
sock = bind_port(port)
|
||||
try:
|
||||
self.assertEqual(sock.getsockname()[1], port)
|
||||
finally:
|
||||
sock.close()
|
||||
|
||||
def test_get_open_port(self):
|
||||
"""get_open_port should return a valid port number."""
|
||||
port = get_open_port()
|
||||
self.assertGreater(port, 0)
|
||||
self.assertLessEqual(port, 65535)
|
||||
|
||||
def test_get_open_port_with_env_var(self):
|
||||
"""get_open_port should respect SGLANG_PORT env var."""
|
||||
free_port = get_free_port()
|
||||
with patch.dict(os.environ, {"SGLANG_PORT": str(free_port)}):
|
||||
port = get_open_port()
|
||||
self.assertEqual(port, free_port)
|
||||
|
||||
def test_get_open_port_env_var_occupied_increments(self):
|
||||
"""get_open_port should increment if SGLANG_PORT is occupied."""
|
||||
sock = bind_port(get_free_port())
|
||||
try:
|
||||
occupied_port = sock.getsockname()[1]
|
||||
with patch.dict(os.environ, {"SGLANG_PORT": str(occupied_port)}):
|
||||
port = get_open_port()
|
||||
# Should skip the occupied port and return a higher one
|
||||
self.assertGreater(port, occupied_port)
|
||||
finally:
|
||||
sock.close()
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Reference in New Issue
Block a user