[Bug] Fix lora tp bug on H200 (#19769)
This commit is contained in:
@@ -541,14 +541,28 @@ class RowParallelLinearWithLoRA(BaseLayerWithLoRA):
|
|||||||
self.base_layer, input_parallel
|
self.base_layer, input_parallel
|
||||||
)
|
)
|
||||||
|
|
||||||
if self.set_lora:
|
should_reduce = (
|
||||||
output_parallel = self.apply_lora(output_parallel, input_parallel)
|
|
||||||
|
|
||||||
if (
|
|
||||||
self.base_layer.reduce_results
|
self.base_layer.reduce_results
|
||||||
and self.base_layer.tp_size > 1
|
and self.base_layer.tp_size > 1
|
||||||
and not skip_all_reduce
|
and not skip_all_reduce
|
||||||
):
|
)
|
||||||
|
|
||||||
|
if self.set_lora and should_reduce:
|
||||||
|
lora_a_output = self.lora_backend.run_lora_a_sgemm(
|
||||||
|
input_parallel, self.A_buffer
|
||||||
|
)
|
||||||
|
output_ = tensor_model_parallel_all_reduce(output_parallel)
|
||||||
|
lora_a_output = tensor_model_parallel_all_reduce(lora_a_output)
|
||||||
|
output_ = self.lora_backend.run_lora_b_sgemm(
|
||||||
|
x=lora_a_output,
|
||||||
|
weights=self.B_buffer,
|
||||||
|
output_offset=self.output_offset,
|
||||||
|
base_output=output_,
|
||||||
|
)
|
||||||
|
else:
|
||||||
|
if self.set_lora:
|
||||||
|
output_parallel = self.apply_lora(output_parallel, input_parallel)
|
||||||
|
if should_reduce:
|
||||||
output_ = tensor_model_parallel_all_reduce(output_parallel)
|
output_ = tensor_model_parallel_all_reduce(output_parallel)
|
||||||
else:
|
else:
|
||||||
output_ = output_parallel
|
output_ = output_parallel
|
||||||
|
|||||||
@@ -32,7 +32,6 @@ from sglang.test.test_utils import CustomTestCase, is_in_ci
|
|||||||
register_cuda_ci(
|
register_cuda_ci(
|
||||||
est_time=116,
|
est_time=116,
|
||||||
suite="stage-b-test-large-2-gpu",
|
suite="stage-b-test-large-2-gpu",
|
||||||
disabled="Disabled due to CI machines transition from H100 to H200, which exposes some potential bugs.",
|
|
||||||
)
|
)
|
||||||
register_amd_ci(
|
register_amd_ci(
|
||||||
est_time=116,
|
est_time=116,
|
||||||
|
|||||||
Reference in New Issue
Block a user