minke.yu/sglang
1
0
Fork 0
Code Issues Pull Requests Actions 12 Packages Projects Releases Wiki Activity

Add fast-fail to multimodal-gen CI (#22284)

Browse Source
This commit is contained in:
Liangsheng Yin
2026-04-07 15:56:12 -07:00
committed by GitHub
parent e6652309c4
commit 0e2a0260a1
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/pr-test-multimodal-gen.yml
+1
View File
@@ -175,6 +175,7 @@ jobs:
with: with:
ref: ${{ inputs.pr_head_sha || inputs.git_ref || github.sha }} ref: ${{ inputs.pr_head_sha || inputs.git_ref || github.sha }}
- uses: ./.github/actions/check-stage-health
- uses: ./.github/actions/check-maintenance - uses: ./.github/actions/check-maintenance
python/sglang/multimodal_gen/test/run_suite.py
+5 -2
View File
@@ -174,12 +174,14 @@ def collect_test_items(files, filter_expr=None):
return test_items return test_items
def run_pytest(files, filter_expr=None): def run_pytest(files, filter_expr=None, exitfirst=False):
if not files: if not files:
print("No files to run.") print("No files to run.")
return 0 return 0
base_cmd = [sys.executable, "-m", "pytest", "-s", "-v"] base_cmd = [sys.executable, "-m", "pytest", "-s", "-v"]
if exitfirst:
base_cmd.append("-x")
# Add pytest -k filter if provided # Add pytest -k filter if provided
if filter_expr: if filter_expr:
@@ -349,7 +351,8 @@ def main():
print(f"Running {len(my_items)} items in this shard: {', '.join(my_items)}") print(f"Running {len(my_items)} items in this shard: {', '.join(my_items)}")
# 4. execute with the specific test items # 4. execute with the specific test items
exit_code = run_pytest(my_items) # Fast-fail: stop on first failure unless --continue-on-error is set
exit_code = run_pytest(my_items, exitfirst=not args.continue_on_error)
# Print tests again at the end for visibility # Print tests again at the end for visibility
msg = "\n" + tabulate.tabulate(rows, headers=headers, tablefmt="psql") + "\n" msg = "\n" + tabulate.tabulate(rows, headers=headers, tablefmt="psql") + "\n"